Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace NoTabsTests with Test::NoTabs #6

Merged
merged 1 commit into from Nov 1, 2015

Conversation

paultcochrane
Copy link
Contributor

The Dist::Zilla plugin NoTabsTests is deprecated in favour of
Test::NoTabs.

The `Dist::Zilla` plugin `NoTabsTests` is deprecated in favour of
`Test::NoTabs`.
chizmw added a commit that referenced this pull request Nov 1, 2015
Replace NoTabsTests with Test::NoTabs
@chizmw chizmw merged commit d0f1279 into chizmw:master Nov 1, 2015
@chizmw
Copy link
Owner

chizmw commented Nov 1, 2015

I'd like to thank you (in one place) for your contributions to this distribution.
I know there are a few strange things going on with this, but (scarily?) it's been used in business critical systems for a couple of years at least.
Anyone adding more stability and sanity gets my thanks.

@paultcochrane
Copy link
Contributor Author

No problems! Only too pleased to help :-) It's also part of my module this month for the CPAN Pull Request Challenge, so that's how I came across the module. I hope I haven't put too much spam in your inbox!

@paultcochrane
Copy link
Contributor Author

By the way: is there anything else I can do to improve the module apart from the things I've worked on so far?

@chizmw
Copy link
Owner

chizmw commented Nov 1, 2015

No spam at all; that's what filters are for :-)

I haven't actively used this module since writing, testing and releasing our work software with it (all that time ago).

I don't have any improvements in the back of my mind and I think most co-workers have forgotten it's even there.

chizmw added a commit that referenced this pull request Nov 15, 2015
 - Merged pull-requests from Paul Cochrane:
   - #6 replace NoTabsTests
   - #7 add missing abstracts (for dzil)
   - #8 add Travis config
   - #9 purge trailing whitespace
   - #10 fix POD errors
   - #11 update dist.ini
   - #12 add missing strictures
   - #13 remove shebang in tests
   - #14 fix typos in POD
   - #15 fix tests on non-English locales
   - #16 increase error severity in call handler
 - Resolve "[PkgVersion] no blank line for $VERSION after package" with dzil prep
 - add skeleton POD for methods
   unhelpfully empty but keeps pod-coverage tests happy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants