Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests break with alpha version of Test::More #12

Closed
exodist opened this issue Nov 4, 2014 · 3 comments
Closed

Tests break with alpha version of Test::More #12

exodist opened this issue Nov 4, 2014 · 3 comments
Assignees
Labels

Comments

@exodist
Copy link

exodist commented Nov 4, 2014

Test-More/test-more#481

It looks like your test file lists a failed test from 'done_testing', your comments around it indicate it should not and that you are hacking around a bug. In the latest alpha version of Test::More this extra result does not occur. This is good news cause it fixes the bug, but is bad news cause it breaks your modules test suite.

The easy fix would be to check if $INC{'Test/Stream.pm'} is set, if it is do not add the extra result.

@chizmw chizmw self-assigned this Nov 30, 2014
chizmw added a commit that referenced this issue Dec 15, 2015
chizmw added a commit that referenced this issue Dec 17, 2015
 - fix tests when Test::More >= 1.3 (issue #12 / pull #15)
 - add buildkite helper scripts (submodule and init)
 - Add weaver.ini; better POD weaving
@eserte
Copy link

eserte commented Apr 23, 2016

1.0.9 (still? again?) is broken with the latest Test::More devel releases (more specifically with Test-Simple-1.302014_003). Failing test output starts with:

#   Failed test 'test output as expected for passing case'
#   at t/40.untested.columns.t line 74.
# STDOUT is:
#   ok 1 - use UnexpectedTest::Schema;
#   ok 2 - An object of class 'UnexpectedTest::Schema' isa 'UnexpectedTest::Schema'
#   ok 3 - The record object is a ::SpanishInquisition
#   ok 4 - 'id' column defined in result_source
#   ok 5 - 'id' column exists in database
#   ok 6 - 'name' column defined in result_source
#   ok 7 - 'name' column exists in database
#   ok 8 # skip no relations methods
#   ok 9 # skip no custom methods
#   ok 10 # skip no resultsets methods
# > not ok 11 - planned to run 4 but done_testing() expects 10
# not:
#   ok 1 - use UnexpectedTest::Schema;
#   ok 2 - An object of class 'UnexpectedTest::Schema' isa 'UnexpectedTest::Schema'
#   ok 3 - The record object is a ::SpanishInquisition
#   ok 4 - 'id' column defined in result_source
#   ok 5 - 'id' column exists in database
#   ok 6 - 'name' column defined in result_source
#   ok 7 - 'name' column exists in database
#   ok 8 # skip no relations methods
#   ok 9 # skip no custom methods
#   ok 10 # skip no resultsets methods
# > 
# as expected

@chizmw chizmw added the BUG label May 10, 2016
chizmw added a commit that referenced this issue May 11, 2016
Also leave ourselves a comment as a reminder for when we have time and energy
to delve into deep, dark magic
chizmw added a commit that referenced this issue May 11, 2016
Also leave ourselves a comment as a reminder for when we have time and energy
to delve into deep, dark magic
chizmw added a commit that referenced this issue May 12, 2016
 - replace ContributorsFromGit with Git::Contributors
 - bump minimum Test::More version to 1.302015
 - add .mailmap file to combine same-author-different-email
 - add required test deps to dist.ini
 - use Test::More 0.92 → 1.302015
 - do not push 'not ok 11' if we find Test2::... (#12)
 - refudge the @expected_out for issue #12
 - add buildkite status badge for builds on master
@chizmw
Copy link
Owner

chizmw commented May 12, 2016

Pushed to CPAN a few minutes ago as 1.0.10

@chizmw chizmw closed this as completed May 12, 2016
@exodist
Copy link
Author

exodist commented May 12, 2016

Test-More/test-more#667 this may interest you, related to the 'wtf' you have in your code in regards to planning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants