@@ -65,27 +65,27 @@ class TestFakeAuthentication < Test::Unit::TestCase assert_equal "secret", response.body end - def test_basic_auth_when_userinfo_contains_at_sign - FakeWeb.register_uri(:get, "http://user%40example.com:secret@example.com", :body => "authorized") + def test_basic_auth_when_userinfo_contains_allowed_unencoded_characters + FakeWeb.register_uri(:get, "http://roses&hel1o,(+$):so;longs=@example.com", :body => "authorized") http = Net::HTTP.new("example.com") request = Net::HTTP::Get.new("/") - request.basic_auth("user@example.com", "secret") + request.basic_auth("roses&hel1o,(+$)", "so;longs=") assert_equal "authorized", http.request(request).body end - def test_basic_auth_when_userinfo_contains_ampersand - FakeWeb.register_uri(:get, "http://roses&hello:solongs@example.com", :body => "authorized") + def test_basic_auth_when_userinfo_contains_encoded_at_sign + FakeWeb.register_uri(:get, "http://user%40example.com:secret@example.com", :body => "authorized") http = Net::HTTP.new("example.com") request = Net::HTTP::Get.new("/") - request.basic_auth("roses&hello", "solongs") + request.basic_auth("user@example.com", "secret") assert_equal "authorized", http.request(request).body end - def test_basic_auth_when_userinfo_contains_space - FakeWeb.register_uri(:get, "http://us%20er:sec%20ret@example.com", :body => "authorized") + def test_basic_auth_when_userinfo_contains_allowed_encoded_characters + FakeWeb.register_uri(:get, "http://us%20er:sec%20%2F%2Fret%3F@example.com", :body => "authorized") http = Net::HTTP.new("example.com") request = Net::HTTP::Get.new("/") - request.basic_auth("us er", "sec ret") + request.basic_auth("us er", "sec //ret?") assert_equal "authorized", http.request(request).body end test/test_fake_authentication.rb 7c1dbfef135515e97e78165078b983aabd5bb60e Chris Kampmeier chris@kampers.net http://github.com/chrisk/fakeweb/commit/2dcd9e67c61b5c783b5b5daafff8d15cb554fb29 2dcd9e67c61b5c783b5b5daafff8d15cb554fb29 2009-07-05T01:20:53-07:00 2009-07-05T01:20:53-07:00 Make the tests for unsafe characters in userinfo strings more thorough 3502a2405c1678593c74bfa3f7b90cb6e63964c3 Chris Kampmeier chris@kampers.net