Skip to content

Commit

Permalink
Merge branch 't/13036b' into major
Browse files Browse the repository at this point in the history
  • Loading branch information
Reinmar committed May 15, 2015
2 parents 69c6724 + 15fca0f commit decf792
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGES.md
Expand Up @@ -11,6 +11,7 @@ Fixed Issues:
* [#13199](http://dev.ckeditor.com/ticket/13199): Fixed: Embedsemantic does not support widget classes.
* [#13003](http://dev.ckeditor.com/ticket/13003): Fixed: Anchors are uploaded when moving them by drag and drop.
* [#13032](http://dev.ckeditor.com/ticket/13032): Fixed: When upload is done notification update should be marked as important.
* [#13036](http://dev.ckeditor.com/ticket/13036): Fixed: Notifications are 10px more to the right.
* Toolbar configurators:
* [#13185](http://dev.ckeditor.com/ticket/13185): Fixed: Wrong position of the suggestion box if there is not enough space below the caret.
* [#13138](http://dev.ckeditor.com/ticket/13138): Fixed: The "Toggle empty elements" button label is unclear.
Expand Down
2 changes: 1 addition & 1 deletion plugins/notification/plugin.js
Expand Up @@ -830,7 +830,7 @@ Area.prototype = {
}

function setCenter() {
area.setStyle( 'left', cssLength( leftBase + contentsRect.width / 2 - notificationWidth / 2 ) );
area.setStyle( 'left', cssLength( leftBase + contentsRect.width / 2 - notificationWidth / 2 - notificationMargin / 2 ) );
}

function setRight() {
Expand Down
10 changes: 10 additions & 0 deletions tests/plugins/notification/manual/notificationposition.html
@@ -0,0 +1,10 @@
<textarea cols="10" id="editor1" name="editor1" rows="10"></textarea>
<script>
var editor = CKEDITOR.replace( 'editor1', {
width: '330px'
} );

editor.on( 'instanceReady', function() {
editor.showNotification( 'foo bar baz bag bug beg big', 'warning' );
} );
</script>
5 changes: 5 additions & 0 deletions tests/plugins/notification/manual/notificationposition.md
@@ -0,0 +1,5 @@
@bender-tags: 4.5.0, tc
@bender-ui: collapsed
@bender-ckeditor-plugins: wysiwygarea, toolbar, notification

Notification should be centered horizontally.

0 comments on commit decf792

Please sign in to comment.