Cell split bug 8024 #148
Closed
Cell split bug 8024 #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey. Thanks for the PR. However, it breaks 3 tests in https://github.com/ckeditor/ckeditor-dev/blob/master/tests/plugins/tabletools/tabletools.js You can read about CKEditor testing environment here - http://docs.ckeditor.com/#!/guide/dev_tests |
|
Unit tests updated and completed.
|
|
Hi Reinmar, Is there more you need to get this PR ready and merged? |
|
Sorry for make you waiting, but December was a totally lost period. I reviewed your changes, rebased the branch, added manual tests and merge to major with e4ad441. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix for http://dev.ckeditor.com/ticket/8024
Shouldn't the table feature 'split cell horizontal/vertical' be switched? 'Split horizontal' actually splits the cell vertical. 'Split vertical' actually splits the cell horizontal.