@@ -1,12 +1,14 @@
Revision history for Perl module Handel
-1.00011
+1.00011 Wed Aug 20 19:32:44 2008
- Order->create($cart) uses storage->has_column instead of can
- Removed Build.PL to make Module::Install happy
- Removed $self->stash->clear call in Checkout->process
- - Checkout->new phases now eval stringsin arrayref correctly
+ - Checkout->new phases now eval strings in arrayref correctly
- Deprecating phase names as constants. Just use strings and be happy.
- Added tests for plugins add_handler using strings
+ - Fixed compat.t tests under 5.10
+ - Fixed storage_dbic_clone.t failure under 5.10
1.00010 Sat Mar 1 13:59:23 2008
- Fixed some perl critic failures
Changes
@@ -5,11 +5,13 @@
,B$
,D$
\B\.svn\b
+\B\.git\b
aegis.log$
\bconfig$
\bbuild$
\.DS_Store$
+
# Avoid Makemaker generated and utility files.
\bMakefile$
\bblib
MANIFEST.SKIP
@@ -25,8 +25,8 @@ BEGIN {
use Handel::Exception qw/:try/;
use Handel::L10N qw/translate/;
- use Clone ();
use Scalar::Util qw/blessed weaken/;
+ use Clone ();
};
__PACKAGE__->constraints_class('Handel::Components::Constraints');
@@ -102,7 +102,10 @@ sub clone {
my $schema = $self->_schema_instance;
$self->_schema_instance(undef);
- my $clone = Clone::clone($self);
+ my $clone = $self->SUPER::clone;
+
+ ## filthy hack until I figure out wtf Clone isn't doing in 5.10
+ $clone->{'connection_info'} = [@{$self->{'connection_info'} || []}];
$self->_schema_instance($schema);
lib/Handel/Storage/DBIC.pm
@@ -12,9 +12,11 @@ BEGIN {
like(shift, qr/deprecated/);
};
use_ok('Handel::Compat');
-
+
## load Handel::Base for tests.
## in the wild, the superclasses already have it
+ ## eat C3 warnings in 5.10
+ local $SIG{__WARN__} = sub{};
use_ok('Handel::Base');
use_ok('Handel::Constraints', 'constraint_uuid');
push @Handel::Compat::ISA, 'Handel::Base';
t/compat.t
@@ -12,7 +12,7 @@ BEGIN {
if($@) {
plan skip_all => 'DBD::SQLite not installed';
} else {
- plan tests => 10;
+ plan tests => 11;
};
use_ok('Handel::Storage::DBIC');
@@ -53,6 +53,7 @@ isnt(refaddr $storage, refaddr $clone, 'clone is not the original');
my $schema = $storage->schema_instance;
is(refaddr $storage->_schema_instance, refaddr $schema, 'clone is a full copy');
my $cloned = $storage->clone;
+isnt(refaddr $storage, refaddr $cloned, 'clone is not the original');
is($cloned->_schema_instance, undef, 'unset clone schema instance');
is(refaddr $storage->schema_instance, refaddr $schema, 'original schema in tact');
t/storage_dbic_clone.t
3e706a957284d89b96cd8f71e72a75d527e6b674
claco
claco@52a70e3a-55ec-0310-b14e-7917f69ecacc
http://github.com/claco/handel/commit/3b068d30fee6c75f1f146ccb69b75761a9623397
3b068d30fee6c75f1f146ccb69b75761a9623397
2008-08-20T16:45:50-07:00
2008-08-20T16:45:50-07:00
Fixed clone failures under 5.10
Fixed compat.t failures under 5.10
git-svn-id: http://svn.icantfocus.com/CPAN/Handel/trunk@2247 52a70e3a-55ec-0310-b14e-7917f69ecacc
9b77cfa046f2c5dca1c4557ea7df1406a5ec6732
claco
claco@52a70e3a-55ec-0310-b14e-7917f69ecacc