CLJS-435: Stack overflow error when adding large numerical keys to maps

IHash implementation for numbers now apply modulo MAX INT on the floor of the number.
clojure · Dec 22, 2012 · 61455e6 · 61455e6
1 parent 19d265d
commit 61455e6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/cljs/cljs/core.cljs b/src/cljs/cljs/core.cljs
@@ -452,7 +452,7 @@
   (-equiv [x o] (identical? x o))
 
   IHash
-  (-hash [o] o))
+  (-hash [o] (js-mod (.floor js/Math o) 2147483647)))
 
 (extend-type boolean
   IHash

diff --git a/test/cljs/cljs/core_test.cljs b/test/cljs/cljs/core_test.cljs
@@ -1778,5 +1778,10 @@
   (assert (instance? js/Error (ex-info "asdf" {:foo 1})))
   (assert (not (instance? cljs.core.ExceptionInfo (js/Error.))))
 
+  ;; CLJS-435
+
+  (assert (= (assoc {} 154618822656 1 261993005056 1)
+             {154618822656 1 261993005056 1}))
+
   :ok
   )