Herwig7 81x #2477

smuzaffar · 2016-08-31T11:08:40Z

No description provided.

…le script (cherry picked from commit d9d82d9)

As suggested by smuzzufar.(cherry picked from commit 7da04fc)

Taking into account the change of path(cherry picked from commit 2bc8c35)

smuzaffar · 2016-08-31T11:08:49Z

please test

cmsbuild · 2016-08-31T11:09:39Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/cmsdist-test-pr/317/console

cmsbuild · 2016-08-31T11:09:41Z

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_8_1_X/gcc530.

@cmsbuild, @smuzaffar, @iahmad-khan, @davidlange6 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

mharrend · 2016-08-31T11:48:24Z

herwigpp-toolfile.spec

-    <environment name="LIBDIR" default="$HERWIGPP_BASE/lib"/>
-    <environment name="INCLUDE" default="$HERWIGPP_BASE/include"/>
+    <environment name="LIBDIR" default="$HERWIGPP_BASE/lib/Herwig7"/>
+    <environment name="INCLUDE" default="$HERWIGPP_BASE/include/Herwig7"/>


@smuzaffar I am sorry it seems that I uploaded not the newest version of the tool file.

All parts with Herwig7 have to be changed to just Herwig as we found out in the old PR.

Sorry for the additional efforts required. If you want and have time this week I will buy you a beer at the CERN R1.

this is your original commit where you had Herwig7. The fix is part of another commit. If you see the final changes (by going to File Changed tab then you will see the right path)

cmsbuild · 2016-08-31T12:19:09Z

-1

Tested at: 6ddfc96

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2477/317/summary.html

I found follow errors while testing this PR

Failed tests: Build

Build:

I found an error when building:

>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/cmsdist-test-pr/CMSSW_8_1_X_2016-08-30-2300/src/GeneratorInterface/HiGenCommon/plugins/HiCentralityBiasFilter.cc 
Entering library rule at GeneratorInterface/Hydjet2Interface
Entering library rule at src/GeneratorInterface/ThePEGInterface/plugins
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/cmsdist-test-pr/CMSSW_8_1_X_2016-08-30-2300/src/GeneratorInterface/ThePEGInterface/src/ThePEGInterface.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/cmsdist-test-pr/CMSSW_8_1_X_2016-08-30-2300/src/GeneratorInterface/ThePEGInterface/src/RandomEngineGlue.cc 
/build/cmsbuild/jenkins-workarea/workspace/cmsdist-test-pr/CMSSW_8_1_X_2016-08-30-2300/src/GeneratorInterface/ThePEGInterface/src/RandomEngineGlue.cc:5:49: fatal error: ThePEG/Interface/ClassDocumentation.h: No such file or directory
compilation terminated.
/build/cmsbuild/jenkins-workarea/workspace/cmsdist-test-pr/CMSSW_8_1_X_2016-08-30-2300/src/GeneratorInterface/ThePEGInterface/src/ThePEGInterface.cc:21:44: fatal error: ThePEG/Utilities/DynamicLoader.h: No such file or directory
compilation terminated.
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/cmsdist-test-pr/CMSSW_8_1_X_2016-08-30-2300/src/GeneratorInterface/ThePEGInterface/src/Proxy.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/cmsdist-test-pr/CMSSW_8_1_X_2016-08-30-2300/src/GeneratorInterface/Pythia6Interface/plugins/Pythia6JetGun.cc

mharrend · 2016-08-31T12:27:45Z

It seems that the madgraphamcatnlo-toolfile.spec file is missing and was not copied to this PR.
Furthermore, the issue with the ThePEG interface is expected since the interface has to be rewritten due to the new Herwig7 version. Can we deactivate the interface for now?

smuzaffar · 2016-08-31T12:50:09Z

you mean madgraph5amcatnlo-toolfile.spec ? I do not see any changes for this file in your repo https://github.com/mharrend/cmsdist/blob/IB/CMSSW_8_1_X/gcc530/madgraph5amcatnlo-toolfile.spec

smuzaffar · 2016-08-31T12:51:22Z

no idea about deactivating ThePEG interface ..... if there are some cmssw changes needed to go with this PR then please make a PR for cmssw repo too

mharrend · 2016-09-02T12:12:16Z

Okay, I have checked the exact error why the compilation fails:
`>> Compiling /build/cmsbuild/jenkins-workarea/workspace/cmsdist-test-pr/CMSSW_8_1_X_2016-08-30-2300/src/GeneratorInterface/ThePEGInterface/src/ThePEGInterface.cc

Compiling /build/cmsbuild/jenkins-workarea/workspace/cmsdist-test-pr/CMSSW_8_1_X_2016-08-30-2300/src/GeneratorInterface/ThePEGInterface/src/RandomEngineGlue.cc
/build/cmsbuild/jenkins-workarea/workspace/cmsdist-test-pr/CMSSW_8_1_X_2016-08-30-2300/src/GeneratorInterface/ThePEGInterface/src/RandomEngineGlue.cc:5:49: fatal error: ThePEG/Interface/ClassDocumentation.h: No such file or directory
compilation terminated.
/build/cmsbuild/jenkins-workarea/workspace/cmsdist-test-pr/CMSSW_8_1_X_2016-08-30-2300/src/GeneratorInterface/ThePEGInterface/src/ThePEGInterface.cc:21:44: fatal error: ThePEG/Utilities/DynamicLoader.h: No such file or directory
compilation terminated.`

The issue is that the two files ThePEG/Utilities/DynamicLoader.h and ThePEG/Interface/ClassDocumentation.h are not found which are referenced by
#include <ThePEG/Utilities/DynamicLoader.h>
and
#include <ThePEG/Interface/ClassDocumentation.h>

Thus, it seems that the include path <ThePEG/...> is not properly set / propagated.

There are now 2 solutions:

We can temporarily deactivate the ThePEG interface which has to be rewritten /refactored anyway soon.
We could check now why the ThePEG include path is not working, but it can happen that we get then later some compilation error if the ThePEG library functions were changed.

What would you propose? I will provide a PR to remove ThePEG from CMSSW, so that we can merge Herwig7 and rewrite the ThePEG interface.

mharrend · 2016-09-02T12:33:39Z

If have now created the following PR in CMSSW cms-sw/cmssw#15704 which removes the deprecated ThePEG interface, afterwards the tests can be started again and will succeed.
@smuzaffar Can you please merge the CMSSW PR and then start the tests.

Please note that the deprecated ThePEG interface will be replaced by a Herwig7 interface which has to be partly rewritten anyway.

cmsbuild · 2016-09-02T13:54:24Z

The tests are being triggered in jenkins.
Using cmssw from cms-sw/cmssw#15704
https://cmssdt.cern.ch/jenkins/job/cmsdist-cmssw-test-pr/73/console

cmsbuild · 2016-09-02T16:53:33Z

-1

Tested at: 6ddfc96

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2477/73/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

RelVals:

When I ran the RelVals I found an error in the following worklfows:
11224.0 step3

runTheMatrix-results/11224.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D3_GenSimFull+DigiFull_2023D3+RecoFullGlobal_2023D3+HARVESTFullGlobal_2023D3/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D3_GenSimFull+DigiFull_2023D3+RecoFullGlobal_2023D3+HARVESTFullGlobal_2023D3.log

1001.0 step1

DAS Error

1003.0 step1

DAS Error

cmsbuild · 2016-09-02T17:10:47Z

The tests are being triggered in jenkins.
Using cmssw from cms-sw/cmssw#15704
https://cmssdt.cern.ch/jenkins/job/cmsdist-cmssw-test-pr/74/console

smuzaffar · 2016-09-05T10:22:00Z

@Degano , this should be tested with cms-sw/cmssw#15704
so tests need to be triggered from cmssw PR

cmsbuild · 2016-09-05T11:25:41Z

-1

Tested at: 6ddfc96

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2477/324/summary.html

I found follow errors while testing this PR

Failed tests: Build

Build:

I found an error when building:

>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/cmsdist-test-pr/CMSSW_8_1_X_2016-09-05-1100/src/GeneratorInterface/HiGenCommon/plugins/HiCentralityBiasFilter.cc 
Entering library rule at GeneratorInterface/Hydjet2Interface
Entering library rule at src/GeneratorInterface/ThePEGInterface/plugins
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/cmsdist-test-pr/CMSSW_8_1_X_2016-09-05-1100/src/GeneratorInterface/ThePEGInterface/src/ThePEGInterface.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/cmsdist-test-pr/CMSSW_8_1_X_2016-09-05-1100/src/GeneratorInterface/ThePEGInterface/src/RandomEngineGlue.cc 
/build/cmsbuild/jenkins-workarea/workspace/cmsdist-test-pr/CMSSW_8_1_X_2016-09-05-1100/src/GeneratorInterface/ThePEGInterface/src/RandomEngineGlue.cc:5:49: fatal error: ThePEG/Interface/ClassDocumentation.h: No such file or directory
compilation terminated.
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/cmsdist-test-pr/CMSSW_8_1_X_2016-09-05-1100/src/GeneratorInterface/ThePEGInterface/src/Proxy.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/cmsdist-test-pr/CMSSW_8_1_X_2016-09-05-1100/src/GeneratorInterface/Pythia6Interface/plugins/Pythia6JetGun.cc 
gmake: **\* [tmp/slc6_amd64_gcc530/src/GeneratorInterface/ThePEGInterface/src/GeneratorInterfaceThePEGInterface/RandomEngineGlue.o] Error 1
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/cmsdist-test-pr/CMSSW_8_1_X_2016-09-05-1100/src/GeneratorInterface/Pythia6Interface/plugins/Pythia6Gun.cc

cmsbuild · 2016-09-06T14:09:47Z

The tests are being triggered in jenkins.
Using cmssw from cms-sw/cmssw#15704
https://cmssdt.cern.ch/jenkins/job/cmsdist-cmssw-test-pr/75/console

cmsbuild · 2016-09-06T18:54:13Z

+1
Tested at: 6ddfc96
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15704/75/summary.html

smuzaffar · 2016-09-07T05:26:03Z

assign generators

smuzaffar · 2016-09-07T05:26:17Z

+externals

cmsbuild · 2016-09-07T05:26:20Z

New categories assigned: generators

@thuer,@perrozzi,@govoni you have been requested to review this Pull request/Issue and eventually sign? Thanks

govoni · 2016-09-07T06:37:07Z

+1

cmsbuild · 2016-09-07T06:38:32Z

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_8_1_X/gcc530 IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

smuzaffar · 2016-09-07T15:57:42Z

cms-sw/cmssw#15704 is still open. This external should go along with the cmssw change.
@davidlange6 , if no objection then you can merge cms-sw/cmssw#15704

mharrend · 2016-10-10T16:26:43Z

Dear @smuzaffar, dear all,

unfortunately due to some path issue Herwig7 is still not working in CMSSW. I have created an issue report to track this bug #2571.

smuzaffar and others added 4 commits August 31, 2016 12:56

resolve conflicts

409e095

Herwig7: Updated MadGraph5aMC@NLO to newest version and updated compi…

3c036a3

…le script (cherry picked from commit d9d82d9)

Update herwigpp.spec removing buildrequirement on lhapdf

68beddd

As suggested by smuzzufar.(cherry picked from commit 7da04fc)

Herwig7: Updated toolfile

6ddfc96

Taking into account the change of path(cherry picked from commit 2bc8c35)

cmsbuild added tests-pending externals-pending pending-signatures orp-pending labels Aug 31, 2016

cmsbuild added tests-started and removed tests-pending labels Aug 31, 2016

mharrend reviewed Aug 31, 2016
View reviewed changes

cmsbuild added tests-rejected and removed tests-started labels Aug 31, 2016

smuzaffar mentioned this pull request Sep 2, 2016

ThePEG interface: Removed it since it is deprecated due to new Herwig… cms-sw/cmssw#15704

Merged

cmsbuild added tests-started and removed tests-rejected labels Sep 2, 2016

cmsbuild added tests-rejected and removed tests-started labels Sep 2, 2016

cmsbuild added tests-pending tests-started and removed tests-rejected tests-pending labels Sep 5, 2016

cmsbuild added tests-rejected and removed tests-started labels Sep 5, 2016

cmsbuild added tests-started and removed tests-rejected labels Sep 6, 2016

cmsbuild added tests-approved and removed tests-started labels Sep 6, 2016

cmsbuild added externals-approved generators-pending and removed externals-pending labels Sep 7, 2016

cmsbuild added fully-signed generators-approved and removed generators-pending pending-signatures labels Sep 7, 2016

ghost merged commit dca45e1 into cms-sw:IB/CMSSW_8_1_X/gcc530 Sep 7, 2016

mharrend mentioned this pull request Oct 10, 2016

Herwig7 installation in CMSSW_8_1_X not working #2571

Closed

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Herwig7 81x #2477

Herwig7 81x #2477

smuzaffar commented Aug 31, 2016

smuzaffar commented Aug 31, 2016

cmsbuild commented Aug 31, 2016 •

edited

cmsbuild commented Aug 31, 2016

mharrend Aug 31, 2016

smuzaffar Aug 31, 2016

cmsbuild commented Aug 31, 2016

mharrend commented Aug 31, 2016

smuzaffar commented Aug 31, 2016

smuzaffar commented Aug 31, 2016

mharrend commented Sep 2, 2016

mharrend commented Sep 2, 2016

cmsbuild commented Sep 2, 2016 •

edited

cmsbuild commented Sep 2, 2016

cmsbuild commented Sep 2, 2016 •

edited

smuzaffar commented Sep 5, 2016

cmsbuild commented Sep 5, 2016

cmsbuild commented Sep 6, 2016 •

edited

cmsbuild commented Sep 6, 2016 •

edited by smuzaffar

smuzaffar commented Sep 7, 2016

smuzaffar commented Sep 7, 2016

cmsbuild commented Sep 7, 2016

govoni commented Sep 7, 2016

cmsbuild commented Sep 7, 2016

smuzaffar commented Sep 7, 2016

mharrend commented Oct 10, 2016

Navigation Menu

Herwig7 81x #2477

Herwig7 81x #2477

Conversation

smuzaffar commented Aug 31, 2016

smuzaffar commented Aug 31, 2016

cmsbuild commented Aug 31, 2016 • edited

cmsbuild commented Aug 31, 2016

mharrend Aug 31, 2016

Choose a reason for hiding this comment

smuzaffar Aug 31, 2016

Choose a reason for hiding this comment

cmsbuild commented Aug 31, 2016

mharrend commented Aug 31, 2016

smuzaffar commented Aug 31, 2016

smuzaffar commented Aug 31, 2016

mharrend commented Sep 2, 2016

mharrend commented Sep 2, 2016

cmsbuild commented Sep 2, 2016 • edited

cmsbuild commented Sep 2, 2016

cmsbuild commented Sep 2, 2016 • edited

smuzaffar commented Sep 5, 2016

cmsbuild commented Sep 5, 2016

cmsbuild commented Sep 6, 2016 • edited

cmsbuild commented Sep 6, 2016 • edited by smuzaffar

smuzaffar commented Sep 7, 2016

smuzaffar commented Sep 7, 2016

cmsbuild commented Sep 7, 2016

govoni commented Sep 7, 2016

cmsbuild commented Sep 7, 2016

smuzaffar commented Sep 7, 2016

mharrend commented Oct 10, 2016

cmsbuild commented Aug 31, 2016 •

edited

cmsbuild commented Sep 2, 2016 •

edited

cmsbuild commented Sep 2, 2016 •

edited

cmsbuild commented Sep 6, 2016 •

edited

cmsbuild commented Sep 6, 2016 •

edited by smuzaffar