Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes backspace problem in python and gdb terminal #2540

Merged

Conversation

iahmad-khan
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iahmad-khan (Ijaz ahmad khan) for branch IB/CMSSW_8_1_X/gcc530.

@cmsbuild, @smuzaffar, @Degano, @iahmad-khan, @davidlange6 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@iahmad-khan
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 30, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/cmsdist-test-pr/348/console

@cmsbuild
Copy link
Contributor

-1

Tested at: 40decd3

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2540/348/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

@smuzaffar
Copy link
Contributor

looks good, unit tests were timed out after 2 hours as this Pr nearly build the full release due to python change.

@smuzaffar
Copy link
Contributor

also looks like it also fixed the

Name collision 'ansi' between
    ansi|ansi/pc-term compatible with color
and ansi|ansi/pc-term compatible with color
...now  ansi/pc-term compatible with color
Cannot remove alias 'ansi/pc-term compatible with color'

type warnings.

@smuzaffar smuzaffar merged commit 610b30e into cms-sw:IB/CMSSW_8_1_X/gcc530 Sep 30, 2016
@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants