fixes py2-h5py dependencies #2581
Conversation
|
A new Pull Request was created by @iahmad-khan (Ijaz ahmad khan) for branch IB/CMSSW_8_1_X/gcc530next. @cmsbuild, @smuzaffar, @iahmad-khan, @davidlange6 can you please review it and eventually sign? Thanks. |
|
please test |
|
The tests are being triggered in jenkins. |
|
@davidlt this should fix the py2-h5py dependency issues. |
| @@ -21,5 +21,3 @@ sed -ideleteme 's|#!.*/bin/python|#!/usr/bin/env python|' \ | |||
| %{i}/${PYTHON_LIB_SITE_PACKAGES}/Cython/Debugger/libpython.py | |||
|
|
|||
| find %{i} -name '*deleteme' -delete | |||
|
|
|||
| find %{i}/${PYTHON_LIB_SITE_PACKAGES} -name '*.egg-info' -print0 | xargs -0 rm -f | |||
There was a problem hiding this comment.
Why this is removed? Long-term policy was that we do not provide egg stuff.
There was a problem hiding this comment.
actually the h5py setup has no way to find our cython without this.
| Requires: python py2-numpy hdf5 | ||
| BuildRequires: py2-setuptools hdf5 | ||
| Requires: python py2-numpy hdf5 py2-six | ||
| BuildRequires: py2-setuptools cython py2-pkgconfig |
There was a problem hiding this comment.
Have you looked into how pkgconfig is being used? We need to ensure it does not go to look into the system.
There was a problem hiding this comment.
I think pkgconfig is only needed if you call setup.py test which we are not calling at build time (may be we should)
| @@ -13,4 +13,3 @@ python setup.py build | |||
|
|
|||
| %install | |||
| python setup.py install --single-version-externally-managed --record=/dev/null --skip-build --prefix=%{i} | |||
| find %{i}/${PYTHON_LIB_SITE_PACKAGES} -name '*.egg-info' -print0 | xargs -0 rm -rf | |||
There was a problem hiding this comment.
Again, way we keeping the eggs?
There was a problem hiding this comment.
same reason as above
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
|
No description provided.