New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zlib: experimental changes (SSE4.2, PCLMUL, AVX2) #2806
Conversation
please test |
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_9_0_X/gcc530. @cmsbuild, @smuzaffar, @iahmad-khan, @davidlange6 can you please review it and eventually sign? Thanks. |
zlib.spec
Outdated
%if "%{cmscompiler}" == "icc" | ||
%define cfgopts CC="icc -fPIC" | ||
### RPM external zlib 1.0 | ||
%if "%{_arch}" == "x86_64" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just use %ifarch x86_64
zlib-build.file
Outdated
%setup -n zlib-%{realversion} | ||
|
||
%build | ||
%if "%{cmscompiler}" == "icc" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need this.
Pull request #2806 was updated. |
fa6fb41
to
00ad51d
Compare
Pull request #2806 was updated. |
please test |
-1 Tested at: 00ad51d
I found an error when building: + sed -ideleteme 's|#!.*/bin/python|#!/usr/bin/env python|' /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/testBuildDir/tmp/BUILDROOT/77fb1fbffff292cc41e74654b14643fd/opt/cmssw/slc6_amd64_gcc530/external/py2-numpy/1.11.1-cms/bin/f2py '/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/testBuildDir/tmp/BUILDROOT/77fb1fbffff292cc41e74654b14643fd/opt/cmssw/slc6_amd64_gcc530/external/py2-numpy/1.11.1-cms/lib/python*/site-packages/numpy-*/EGG-INFO/scripts/f2py' '/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/testBuildDir/tmp/BUILDROOT/77fb1fbffff292cc41e74654b14643fd/opt/cmssw/slc6_amd64_gcc530/external/py2-numpy/1.11.1-cms/lib/python*/site-packages/numpy-*/numpy/core/tests/test_arrayprint.py' '/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/testBuildDir/tmp/BUILDROOT/77fb1fbffff292cc41e74654b14643fd/opt/cmssw/slc6_amd64_gcc530/external/py2-numpy/1.11.1-cms/lib/python*/site-packages/numpy-*/numpy/distutils/from_template.py' '/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/testBuildDir/tmp/BUILDROOT/77fb1fbffff292cc41e74654b14643fd/opt/cmssw/slc6_amd64_gcc530/external/py2-numpy/1.11.1-cms/lib/python*/site-packages/numpy-*/numpy/distutils/conv_template.py' sed: can't read /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/testBuildDir/tmp/BUILDROOT/77fb1fbffff292cc41e74654b14643fd/opt/cmssw/slc6_amd64_gcc530/external/py2-numpy/1.11.1-cms/lib/python*/site-packages/numpy-*/EGG-INFO/scripts/f2py: No such file or directory sed: can't read /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/testBuildDir/tmp/BUILDROOT/77fb1fbffff292cc41e74654b14643fd/opt/cmssw/slc6_amd64_gcc530/external/py2-numpy/1.11.1-cms/lib/python*/site-packages/numpy-*/numpy/core/tests/test_arrayprint.py: No such file or directory sed: can't read /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/testBuildDir/tmp/BUILDROOT/77fb1fbffff292cc41e74654b14643fd/opt/cmssw/slc6_amd64_gcc530/external/py2-numpy/1.11.1-cms/lib/python*/site-packages/numpy-*/numpy/distutils/from_template.py: No such file or directory sed: can't read /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/testBuildDir/tmp/BUILDROOT/77fb1fbffff292cc41e74654b14643fd/opt/cmssw/slc6_amd64_gcc530/external/py2-numpy/1.11.1-cms/lib/python*/site-packages/numpy-*/numpy/distutils/conv_template.py: No such file or directory error: Bad exit status from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/testBuildDir/tmp/rpm-tmp.c7B5EW (%install) RPM build errors: Bad exit status from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/testBuildDir/tmp/rpm-tmp.c7B5EW (%install) You can see the results of the tests here: |
-1 Tested at: 00ad51d You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test TestFWCorePythonFrameworkDriver had ERRORS |
Comparison job queued. |
Comparison is ready The workflows 1003.0, 1001.0, 1000.0, 140.53, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons |
unit test failure is not due to this PR |
+externals |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_9_0_X/gcc530 IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
This is identical to #2795 but zlib package now either depends on zlib-x86_64 or zlib-non-x86_64.
The following is a mix of Cloudfare + Brian + orignal zlib. Some
internal functions are implemented with SSE4.2, PCLMUL and AVX2.
Those are picked at load time. This still builds on "generic" machine.