Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relocate blackhat config/la files to avoid hardcoded buildpath #2834

Merged
merged 1 commit into from Feb 17, 2017

Conversation

smuzaffar
Copy link
Contributor

Looks like sherpa picks up hard-coded build paths of blackhat and fails

libtool: compile:  g++ -Wl,--no-as-needed -DHAVE_CONFIG_H -I. -I../.. -I../../ATOOLS/Org -I../.. -I/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/a13024db34d10b69c878c16413f2aa88/opt/cmssw/slc6_amd64_gcc530/external/blackhat/0.9.9-oenich2/include -g -O2 -fuse-cxa-atexit -O2 -std=c++0x -I/build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/slc6_amd64_gcc530/external/lhapdf/6.1.6-oenich3/include -I/build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/slc6_amd64_gcc530/external/blackhat/0.9.9-oenich2/include -I/build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/slc6_amd64_gcc530/external/openssl/1.0.2d/include -MT libSherpaBlackHat_la-BlackHat_Interface.lo -MD -MP -MF .deps/libSherpaBlackHat_la-BlackHat_Interface.Tpo -c BlackHat_Interface.C  -fPIC -DPIC -o .libs/libSherpaBlackHat_la-BlackHat_Interface.o
cc1plus: error: /build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/a13024db34d10b69c878c16413f2aa88/opt/cmssw/slc6_amd64_gcc530/external/blackhat/0.9.9-oenich2/include: Permission denied
make[3]: *** [libSherpaBlackHat_la-BlackHat_Interface.lo] Error 1
make[3]: Leaving directory `/build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/BUILD/slc6_amd64_gcc530/external/sherpa/2.2.1-oenich5/sherpa-2.2.1/AddOns/BlackHat'

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 17, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17843/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_9_0_X/gcc530.

@cmsbuild, @smuzaffar, @iahmad-khan, @davidlange6 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@smuzaffar
Copy link
Contributor Author

type bugfix

@cmsbuild
Copy link
Contributor

-1

Tested at: 3f8628b

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2834/17843/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test TestFWCorePythonFrameworkDriver had ERRORS

@cmsbuild
Copy link
Contributor

Comparison job queued.

@smuzaffar smuzaffar merged commit 3a7e2c3 into IB/CMSSW_9_0_X/gcc530 Feb 17, 2017
@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2834/17843/summary.html

The workflows 1003.0, 1001.0, 1000.0, 140.53, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

@davidlt
Copy link
Contributor

davidlt commented Feb 18, 2017

Remove '*.la' files from the package.

@smuzaffar smuzaffar deleted the blackhat-relocate-90x branch February 18, 2017 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants