Add professor2 #2891
Add professor2 #2891
Conversation
|
A new Pull Request was created by @mkirsano (Mikhail Kirsanov) for branch IB/CMSSW_9_1_X/gcc530. @cmsbuild, @smuzaffar, @iahmad-khan, @davidlange6 can you please review it and eventually sign? Thanks. |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
| <environment name="PROFESSOR2_BASE" default="@TOOL_ROOT@"/> | ||
| </client> | ||
| <use name="py2-numpy"/> | ||
| <use name="py2-sympy"/> |
There was a problem hiding this comment.
here and elsewhere, the py2-sympy tool won't be directly available - you should depend on py2-pippkgs instead.
There was a problem hiding this comment.
@davidlange6 , all of the py2-pippkgs tools are also separately available. So it is better to explicitly mention the dependency.
scram tool info py2-sympy
Tool info as configured in location /tmp/muzaffar/CMSSW_9_1_X_2017-03-07-2300
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Name : py2-sympy
Version : 1.0
++++++++++++++++++++
SCRAM_PROJECT=no
USE=py2-pippkgs
|
ah - ok - so its only the Requires:... in specs that should be updated..(so in professor2.spec)
… On Mar 8, 2017, at 10:53 AM, Malik Shahzad Muzaffar ***@***.***> wrote:
@smuzaffar commented on this pull request.
In professor2-toolfile.spec:
> +### RPM external professor2-toolfile 1.0
+Requires: professor2
+%prep
+
+%build
+
+%install
+
+mkdir -p %i/etc/scram.d
+cat << \EOF_TOOLFILE >%i/etc/scram.d/professor2.xml
+<tool name="professor2" ***@***.***_VERSION@">
+<client>
+<environment name="PROFESSOR2_BASE" ***@***.***_ROOT@"/>
+</client>
+<use name="py2-numpy"/>
+<use name="py2-sympy"/>
@davidlange6 , all of the py2-pippkgs tools are also separately available. So it is better to explicitly mention the dependency.
scram tool info py2-sympy
Tool info as configured in location /tmp/muzaffar/CMSSW_9_1_X_2017-03-07-2300
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Name : py2-sympy
Version : 1.0
++++++++++++++++++++
SCRAM_PROJECT=no
USE=py2-pippkgs
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
ah right ..... having Requires directly on py2-sympy (and others) means these packages will be distributed. |
|
Pull request #2891 was updated. |
|
please test |
|
The tests are being triggered in jenkins. |
|
assuming tests are ok, this looks good to me. |
|
-1 Tested at: 6e57192 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/10042.0_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step4_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log |
|
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
No description provided.