Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jemalloc: update to 4.5.0 and enable statistics #2988

Merged
merged 1 commit into from May 9, 2017

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Apr 28, 2017

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for branch IB/CMSSW_9_1_X/gcc530.

@cmsbuild, @smuzaffar, @iahmad-khan, @davidlange6 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 28, 2017

I've run a test comparing the performance of

  • jemalloc 4.3.1, --disable-stats
  • jemalloc 4.3.1, --enable-stats
  • jemalloc 4.5.0, --disable-stats
  • jemalloc 4.5.0, --enable-stats

running the 2016 HLT menu over data, with 4 streams and 4 threads, with CMSSW_9_1_X_2017-04-20-2300, on an Ivy-Bridge Xeon.

As you can see in the plots, there is basically no difference (anything below 1 ms is just noise):

event processing time real
event processing time cpu

@davidlt
Copy link
Contributor

davidlt commented Apr 28, 2017

+1 from my side, GCC 7 branch used to run on 4.5.0 with no visible issues. More interesting changes happen after 4.5.0 release.

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19498/console

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2988/19498/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1690 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1778721
  • DQMHistoTests: Total failures: 41938
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1736610
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@smuzaffar
Copy link
Contributor

We have enabled stats for DEVEL IBs and do not see any performance issues
https://cmskibana-dev.cern.ch/_plugin/kibana/#/dashboard/temp/AVvX63p8L4W9VqGCeDww
@davidlange6 , I propose to include it in 92X normal IBs and then merge this for 91X in couple of days?

@smuzaffar smuzaffar merged commit d33f95d into cms-sw:IB/CMSSW_9_1_X/gcc530 May 9, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017

backport failed
Reason:

Error: Failed to cherry-pick commits. Please backport this PR yourself.

# On branch backport-IB_CMSSW_9_2_X_gcc530-2988
nothing to commit (working directory clean)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants