Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add C++ wrappers for the CUDA API #3691

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Jan 25, 2018

Add C++ wrappers for the CUDA API from https://github.com/eyalroz/cuda-api-wrappers

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for branch IB/CMSSW_10_1_X/gcc630.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 25, 2018

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 25, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25635/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@smuzaffar
Copy link
Contributor

@fwyzard , I see following error message in the build log https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3691/25635/external/cuda-api-wrappers/20180125/log . Is this expected?

-- Found CUDA: /build/cmsbld/jenkins/workspace/ib-any-integration/testBuildDir/slc6_amd64_gcc630/external/cuda/9.1.85-cms (found suitable version "9.1", minimum required is "7.0") 
/tmp/cuda-compute-version-helper-23001-1516918207.316623085: error while loading shared libraries: libcudart.so.9.1: cannot open shared object file: No such file or directory
-- CUDA device-side code will assume compute capability 

@fwyzard fwyzard force-pushed the IB/CMSSW_10_0_X/gcc630_add_cuda-api-wrappers branch from 8807fd0 to b603012 Compare January 26, 2018 22:43
@cmsbuild
Copy link
Contributor

Pull request #3691 was updated.

@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 26, 2018

Hi @smuzaffar, that would only affect the tests, which we don't actually build.
Anyway, I've updated the spec file to pass some parameters explicitly, which should avoid the error.

@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 26, 2018

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 26, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25671/console

@cmsbuild
Copy link
Contributor

-1

Tested at: b603012

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3691/25671/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

The relvals timed out after 2 hours.
When I ran the RelVals I found an error in the following worklfows:
4.22 step2

runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log

136.7611 step2
runTheMatrix-results/136.7611_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM/step2_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM.log

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 27, 2018

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 27, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25685/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3691/25685/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-3691/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2464350
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2464180
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.960000000101 KiB( 22 files compared)
  • Checked 110 log files, 9 edm output root files, 26 DQM output files

@smuzaffar smuzaffar merged commit 198ebdb into cms-sw:IB/CMSSW_10_1_X/gcc630 Jan 27, 2018
@fwyzard fwyzard deleted the IB/CMSSW_10_0_X/gcc630_add_cuda-api-wrappers branch February 16, 2018 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants