Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport vecgeom to 10_0_X #3705

Merged

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented Feb 1, 2018

Add vecgeom to 10_0_X from 10_1_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2018

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_10_0_X/gcc630.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@mrodozov
Copy link
Contributor Author

mrodozov commented Feb 1, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25843/console

@smuzaffar
Copy link
Contributor

ping

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2018

-1

Tested at: bc2f7c5

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3705/25843/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test Cons_ had ERRORS

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2018

Comparison job queued.

@smuzaffar
Copy link
Contributor

Cons_ is broken due to vecgeom. we need to backport cms-sw/cmssw#21898 in to 10.0.X to fix this.

@smuzaffar smuzaffar merged commit 72e049d into cms-sw:IB/CMSSW_10_0_X/gcc630 Feb 1, 2018
@smuzaffar
Copy link
Contributor

@fabiocos , vecgeom should be part of next 10.0.X IB. One unit test fail which we can fix if we get cms-sw/cmssw#21898 in to 10.0.X

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3705/25843/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-3705/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

  • You potentially added 7 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 23794 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2468773
  • DQMHistoTests: Total failures: 95452
  • DQMHistoTests: Total nulls: 5
  • DQMHistoTests: Total successes: 2373147
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.0700000001 KiB( 22 files compared)
  • Checked 110 log files, 9 edm output root files, 26 DQM output files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants