Make a switch from das_client to dasgoclient (DO NOT MERGE)

[vkuznet]

No description provided.

[cmsbuild]

A new Pull Request was created by @vkuznet (Valentin Kuznetsov) for branch IB/CMSSW_10_1_X/gcc630.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

[vkuznet]

Please do not merge yet this PR. It is proposal to review before making a switch. @smuzaffar could you please review and let me know if this is what we need. If so, per our DM agreement we need to perform a switch on last day of March.

[smuzaffar]

@vkuznet , one problem which we will have is that if someone install an old cmssw release after installing this? old release will bring an old das_client which will override the das_client symlink. I would suggest to drop the above change and make use of override/bin/das_client. No package yet creates share/overrides/bin/das_client so I would suggest to create override/bin/das_client symlink pointing to common/dasgocleint.

Only issue left is for those release where we call das_client.py (which is already in available in share/override/bin) and I do not see any simple solution for this.

[smuzaffar]

@vkuznet , please see my comment https://github.com/cms-sw/cmsdist/pull/3869/files#r176945764
plus I would suggest to drop the das_client-toolfile dependency here https://github.com/cms-sw/cmsdist/blob/IB/CMSSW_10_1_X/gcc630/cmssw-tool-conf.spec#L25

[cmsbuild]

Pull request #3869 was updated.

[vkuznet]

Shahzad, I dropped requested block and I agree that we can remove das_client-toolfile but probably after the switch. Please review and decide when to merge.

[smuzaffar]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27102/console

[smuzaffar]

@vkuznet , I am fine with the change. Should we merge it today so that it become part of 10.1.0 release and get deployed? Note that 10.1.0 will be out tomorrow or day after tomorrow.

[cmsbuild]

+1
Tested at: 271e1d1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3869/27102/summary.html

[cmsbuild]

Comparison job queued.

[vkuznet]

Yes, let's merged today.

…

On 0, Malik Shahzad Muzaffar ***@***.***> wrote: @vkuznet , I am fine with the change. Should we merge it today so that it become part of 10.1.0 release and get deployed? Note that 10.1.0 will be out tomorrow or day after tomorrow. -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #3869 (comment)

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3869/27102/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2498300
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2498123
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.39000000009 KiB( 22 files compared)
• Checked 118 log files, 9 edm output root files, 29 DQM output files