Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PhysicsTools-NanoAOD to tag V01-00-02 #3888

Merged

Conversation

cmsbuild
Copy link
Contributor

backport of #3887

Description: cms-data/PhysicsTools-NanoAOD#3

@mrodozov
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Mar 28, 2018

A new Pull Request was created by @cmsbuild for branch IB/CMSSW_9_4_X/gcc630.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor Author

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Mar 28, 2018

The tests are being triggered in jenkins.
Using cmssw from cms-sw/cmssw#22753
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27163/console

@cmsbuild
Copy link
Contributor Author

-1

Tested at: 3923235

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
3c6ac7f
a4229a2
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3888/27163/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3888/27163/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22753/27163/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test runtestPhysicsToolsNanoAOD had ERRORS

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
3c6ac7f
a4229a2
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3888/27163/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3888/27163/git-merge-result

@cmsbuild
Copy link
Contributor Author

Comparison job queued.

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Mar 28, 2018

The tests are being triggered in jenkins.
Using cmssw from cms-sw/cmssw#22753
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27170/console

@cmsbuild
Copy link
Contributor Author

@cmsbuild
Copy link
Contributor Author

Comparison job queued.

@mrodozov
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor Author

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_9_4_X/gcc630 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Apr 1, 2018

+1

@cmsbuild cmsbuild merged commit a81ad48 into IB/CMSSW_9_4_X/gcc630 Apr 1, 2018
@smuzaffar smuzaffar deleted the backport-IB_CMSSW_9_4_X_gcc630-3887 branch April 11, 2018 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants