Fix for Legacy2016 Smearings cms-data/EgammaAnalysis-ElectronTools#6 …

[fabiocos]

Backport of #4036

[cmsbuild]

A new Pull Request was created by @fabiocos (Fabio Cossutti) for branch IB/CMSSW_9_4_X/gcc630.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

• Backported from Update data-EgammaAnalysis-ElectronTools.spec #4036

[fabiocos]

@smuzaffar @slava77 this should be tested on top of CMSSW_9_4_MAOD_X

[slava77]

On 5/31/18 7:28 AM, Fabio Cossutti wrote: @smuzaffar <https://github.com/smuzaffar> @slava77 <https://github.com/slava77> this should be tested on top of CMSSW_9_4_MAOD_X —

Is there a way to do it with cms-bot/jenkins?

[smuzaffar]

not automatically via "please test" command but once job starts in jenkins then I can change the release format to be 9.4.maod.x

[fabiocos]

please test

@smuzaffar so please change the release directly in jenkins, thanks

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28342/console

[cmsbuild]

+1
Tested at: 74d93e1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4062/28342/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4062/28342/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2721493
• DQMHistoTests: Total failures: 104
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2721227
• DQMHistoTests: Total skipped: 162
• DQMHistoTests: Total Missing objects: 0

[slava77]

Reco comparison results: 4 differences found in the comparisons

these are in the expected places in the 2016 re-miniAOD workflow 136.7611

I expect that the MC part should behave the same as in the 10_2_X tests mentioned in
#4036 (comment)

[smuzaffar]

+externals

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_9_4_X/gcc630 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@slava77 changes specific to MC are from PixelPhase1v DQM, that shows non reproducibility on 94X and looks to me unrelated to this PR

[fabiocos]

+1