Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

geant4: Fixed muon stopping #4143

Merged
merged 1 commit into from Jun 23, 2018
Merged

geant4: Fixed muon stopping #4143

merged 1 commit into from Jun 23, 2018

Conversation

smuzaffar
Copy link
Contributor

As requested here cms-externals/geant4#33

@smuzaffar
Copy link
Contributor Author

please test

@smuzaffar smuzaffar mentioned this pull request Jun 22, 2018
Closed
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 22, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28821/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_10_2_X/gcc630.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

+1
Tested at: 43db73f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4143/28821/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4143/28821/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2899538
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2899347
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@smuzaffar
Copy link
Contributor Author

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_2_X/gcc630 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar merged commit 5aebe81 into IB/CMSSW_10_2_X/gcc630 Jun 23, 2018
smuzaffar added a commit that referenced this pull request Jun 25, 2018
@smuzaffar
[9.3.X] [Geant4]: Fixed muon stopping
49b8c4a 
backport of #4143
This include updates propose here: cms-externals/geant4#34
@smuzaffar smuzaffar mentioned this pull request Jun 25, 2018
Merged
smuzaffar added a commit that referenced this pull request Jun 25, 2018
@smuzaffar
[9.4.X][Geant4]: Fixed muon stopping + G4 bug in indexes
d749ae2 
backport of #4143
This PR includes two updates
- cms-externals/geant4#34: Fixed muon stopping
- cms-externals/geant4#29: G4 bug in indexes inside decay class. This wnet in 93X but not 94X
@smuzaffar smuzaffar mentioned this pull request Jun 25, 2018
Merged
@smuzaffar smuzaffar deleted the smuzaffar-patch-2 branch June 28, 2018 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
externals-approved fully-signed orp-pending tests-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smuzaffar @cmsbuild