Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CUDA build rules to support linking device code across different libraries #4168

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Jul 3, 2018

Update to the CUDA tool:

  • drop -dlink, which should be moved to the SCRAM build rules
  • drop -shared, which should be replaced by --compiler-options '$(CXXSHAREDOBJECTFLAGS)' in the SCRAM build rules, which includes -fPIC
  • drop -L$(CUDA_BASE)/lib64, which is included automatically by nvcc

Update to the SCRAM build rules for CUDA code (by Shahzad):

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2018

A new Pull Request was created by @fwyzard (Andrea Bocci) for branch IB/CMSSW_10_2_X/gcc630.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 3, 2018

@smuzaffar , these changes should go together with the upcoming changes to the build rules for CUDA code.

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 3, 2018

These upcoming changes: cms-sw/cmssw-config#65 .

@fwyzard fwyzard force-pushed the IB/CMSSW_10_2_X/gcc630_fix_CUDA_LDFLAGS branch from d86f1fc to 1d0f3d4 Compare July 6, 2018 23:45
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2018

Pull request #4168 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2018

Pull request #4168 was updated.

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 6, 2018

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29039/console

@fwyzard fwyzard changed the title Fix CUDA_LDFLAGS Improve CUDA build rules to support linking device code across different libraries Jul 6, 2018
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4168/29039/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2899480
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2899288
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@smuzaffar smuzaffar merged commit 841a1a1 into cms-sw:IB/CMSSW_10_2_X/gcc630 Jul 7, 2018
@fwyzard fwyzard deleted the IB/CMSSW_10_2_X/gcc630_fix_CUDA_LDFLAGS branch August 28, 2018 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants