Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix: make sure that share/data has correct content after local deprecate local and re-install #4169

Merged
merged 1 commit into from Jul 5, 2018

Conversation

smuzaffar
Copy link
Contributor

This is a bug fix to avoid the following situation when building with --reference /cvmfs/cms-ib.cern.ch/weekN as reference repository

  • A data package is build locally means arch/cms/data-SubSys-Pack/version/SubSys is symlink to share/cms/data-SubSys-Pack/version/SubSys
  • newly built RPMs are uploaded
  • run deprecate local to force get newly uploaded RPMs. This means rpm erase will remove the contents of arch/cms/data-SubSys-Pack/version/SubSys (which is symlink to share/cms/data-SubSys-Pack/version/SubSys).
  • We when re-install this data package from the uploaded repo it does not re-populate the contents of share directory.

This PR should fix this situation.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2018

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_10_2_X/gcc630.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4169/29012/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2899480
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2899288
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@smuzaffar
Copy link
Contributor Author

+externals

@smuzaffar smuzaffar merged commit de3e0d7 into IB/CMSSW_10_2_X/gcc630 Jul 5, 2018
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2018

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_2_X/gcc630 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants