Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add geneva generator #4405

Merged
merged 7 commits into from Nov 21, 2018
Merged

Conversation

mkirsano
Copy link
Contributor

@mkirsano mkirsano commented Oct 3, 2018

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2018

A new Pull Request was created by @mkirsano (Mikhail Kirsanov) for branch IB/CMSSW_10_3_X/gcc700.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@alberto-sanchez
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30882/console

geneva.spec Outdated
%prep
%setup -q -n %{n}-%{realversion}

mkdir build
Copy link
Contributor

@smuzaffar smuzaffar Oct 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkirsano , can you please

geneva.spec Outdated
### RPM external geneva 1.0-RC3
Source: git+https://stash.desy.de/scm/geneva/geneva-public.git?obj=master/%{realversion}&export=%{n}-%{realversion}&output=/%{n}-%{realversion}-%{tag}.tgz

BuildRequires: cmake
Copy link
Contributor

@smuzaffar smuzaffar Oct 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add dependency on gmake here.

geneva.spec Outdated

%build
cd build
make LHAPDF_DATA_PATH=${LHAPDF_ROOT}/share/LHAPDF
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be build in parallel if yes then please add %{makeprocesses}

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2018

Pull request #4405 was updated.

@mkirsano
Copy link
Contributor Author

mkirsano commented Oct 4, 2018

@smuzaffar, I did not understand about gamke, there is no such tool

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2018

Pull request #4405 was updated.

@smuzaffar
Copy link
Contributor

oops sorry typo, it is gmake

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4405/30882/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3162909
  • DQMHistoTests: Total failures: 172
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3162540
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2018

Pull request #4405 was updated.

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30895/console

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4405/30988/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 2995443
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2995245
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@smuzaffar
Copy link
Contributor

+externals
@fabiocos , this is new generator. Feel free to merge it for 10.4.X

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_4_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

"It is just that this package will not be available for python3. "

that is to say the lifetime make be only though the 10_4_X cycle in production..

@fabiocos
Copy link
Contributor

@davidlange6 @smuzaffar this is indeed a problem. This generator is under discussion since several years, and interesting from the physics point of view for precision studies. But if it is bound to python2 I agree we merge it now to kick it out in a few month: does it make sense?

@mkirsano @efeyazgan @qliphy @alberto-sanchez did you contact the authors about this technical but important issue for the medium-long term maintainability?

@davidlange6
Copy link
Contributor

davidlange6 commented Oct 12, 2018 via email

@fabiocos
Copy link
Contributor

@davidlange6 well, I assume people will want to have official productions with it, with the idea of carrying it forward as we do for other tools (e.g. madgraph, powheg, sherpa...) So I am afraid it will not just be a Run2 standalone effort restricted to 10_4_X, at least this is not what I would expect

@davidlange6
Copy link
Contributor

davidlange6 commented Oct 12, 2018 via email

@bendavid
Copy link
Contributor

Expected usage of this is similar to madgraph, with an external executable called from ExternalLHEProducer or similar producing an LHE file, which is then showered by pythia within CMSSW, so as long as python2 is available within the environment it should be ok.

@davidlange6
Copy link
Contributor

davidlange6 commented Oct 12, 2018 via email

@mkirsano
Copy link
Contributor Author

The authors said that they don't have concrete plans about python 3 support, but if it is needed for CMS, thay can put some priority in this and work on it. So far they were responsive and helpful. In RC3 they solved all problems reported about RC2.

@davidlange6
Copy link
Contributor

davidlange6 commented Oct 12, 2018 via email

@fabiocos
Copy link
Contributor

@mkirsano @alberto-sanchez @efeyazgan @qliphy there was any clarification about the timescale for a python3 update of the existing code? The questions not "whether" we need it but "when" it might become available

@mkirsano
Copy link
Contributor Author

I informed the authors that we need the compatibility with python 3 as soon as possible, in any case it should be compatible early next year. The answer is:

We'll look into migrating to python 3 and prioritize it accordingly.
I'll keep you updated ...

@smuzaffar
Copy link
Contributor

smuzaffar commented Nov 21, 2018

please test
just to get a fresh test result

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 21, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31791/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4405/31791/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3013311
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3013110
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@smuzaffar smuzaffar merged commit a540f9c into cms-sw:IB/CMSSW_10_4_X/gcc700 Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants