Updated root to tip of branch v6-12-00-patches

[mrodozov]

No description provided.

[mrodozov]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30959/console
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30970/console

[cmsbuild]

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_10_4_X/gcc700.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

[cmsbuild]

-1

Tested at: 299a638

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4417/30970/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4417/30970/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 182 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 2995443
• DQMHistoTests: Total failures: 84
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2995162
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[slava77]

This PR introduced a crash in runtestPhysicsToolsPatAlgos.

It would be nice to not ignore somewhat clear problems in ROOT I/O.

The symptoms also include a problem earlier seen in test builds and reported in cms-sw/cmssw#22594 (comment)
where a file 02FB8769-5433-E711-BBDE-0025905A6076.root from /JetHT/Run2016E-18Apr2017-v1/AOD shows a crash on exit from the root session when doing en->Scan("recoPFJets_ak4PFJets__RECO.obj.energy()");

I propose to revert.

@fabiocos

[fabiocos]

@slava77 this was not ignored, I discussed it with Shahzad and Chris, and yesterday I think we agreed to wait for a few days a possible fix, or revert this PR before 10_4_0_pre1 is built

[slava77]

looking around a bit more, I see that validateJR scripts running on miniAOD files are crashing
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_10_4_X_2018-10-15-2300+24432/28943/validateJR/all_mini_OldVSNew_TTbar13TeVPUppmx2018wf250202p181/all_mini_OldVSNew_TTbar13TeVPUppmx2018wf250202p181.log

I will not be able to sign any [new, non-trivial] reco PRs without the fix/revert.

[slava77]

@slava77 this was not ignored

related to my comment

It would be nice to not ignore somewhat clear problems in ROOT I/O.

I meant to not ignore the failures in tests before merging an external.

[fabiocos]

@DRJONES15 @smuzaffar is there any news about a possible fix? Otherwise I would say let's just revert the patch