Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RecoBTag-Combined: Update to new tag V01-01-00 #4432

Merged
merged 3 commits into from Nov 16, 2018

Conversation

mrodozov
Copy link
Contributor

Description of the change: cms-data/RecoBTag-Combined#17

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_10_4_X/gcc700.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@mrodozov
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 18, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31127/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 18, 2018

The tests are being triggered in jenkins.
Using cmssw from cms-sw/cmssw#24918
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31128/console

@cmsbuild
Copy link
Contributor

-1

Tested at: 20a30c1

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4432/31127/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test testNumba had ERRORS
---> test testImports had ERRORS

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

-1

Tested at: 20a30c1

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24918/31128/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test testNumba had ERRORS
---> test testImports had ERRORS

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4432/31127/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 2994843
  • DQMHistoTests: Total failures: 15
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2994631
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 19, 2018

The tests are being triggered in jenkins.
Using cmssw from cms-sw/cmssw#24918
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31149/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 29, 2018

The tests are being triggered in jenkins.
Using cmssw from cms-sw/cmssw#24918
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31331/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 13, 2018

The tests are being triggered in jenkins.
Using cmssw from cms-sw/cmssw#24918
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31627/console

@cmsbuild
Copy link
Contributor

Comparison job queued.

@slava77
Copy link
Contributor

slava77 commented Nov 14, 2018

@cmsbuild please test

checking if this can be integrated by itself (without a coupled merge of cms-sw/cmssw#24918 )

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 14, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31653/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4432/31653/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3013311
  • DQMHistoTests: Total failures: 16
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3013098
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@slava77
Copy link
Contributor

slava77 commented Nov 15, 2018

Reco comparison results: 0 differences found in the comparisons

It looks like this PR can go in by itself, not coupled to merging of cms-sw/cmssw#24918 .
Also, the current state of cms-sw/cmssw#24918 suggests that the updates introduced in this external are OK.

@mrodozov @smuzaffar @fabiocos please proceed with integration of this to the IB.

@smuzaffar smuzaffar merged commit 181732d into IB/CMSSW_10_4_X/gcc700 Nov 16, 2018
@cmsbuild
Copy link
Contributor

Pull request #4432 was updated.

@smuzaffar smuzaffar deleted the mrodozov-patch-2 branch November 16, 2018 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants