Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated dd4hep to tip of branch master #4487

Merged
merged 1 commit into from Nov 9, 2018
Merged

Updated dd4hep to tip of branch master #4487

merged 1 commit into from Nov 9, 2018

Conversation

gudrutis
Copy link
Contributor

@gudrutis gudrutis commented Nov 9, 2018

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018

A new Pull Request was created by @gudrutis (Zygimantas Matonis) for branch IB/CMSSW_10_4_X/gcc700.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@ianna
Copy link

ianna commented Nov 9, 2018

@gudrutis - Thanks!

@gudrutis
Copy link
Contributor Author

gudrutis commented Nov 9, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31552/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4487/31552/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-4487/7.3_CosmicsSPLoose_UP18+CosmicsSPLoose_UP18+DIGICOS_UP18+RECOCOS_UP18+ALCACOS_UP18+HARVESTCOS_UP18

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3013827
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3013629
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_4_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar merged commit 96f15d8 into cms-sw:IB/CMSSW_10_4_X/gcc700 Nov 9, 2018
@ianna
Copy link

ianna commented Nov 12, 2018

@smuzaffar - is the following warning/error due to the update?

Warning in <TStreamerInfo::BuildCheck>: 
   The StreamerInfo of class TGeoVolume read from file /build/yana/DD4HEP/CMSSW_10_4_X_2018-11-11-2300/src/./cmsDD4HepGeom.root
   has the same version (=6) as the active class but a different checksum.
   You should update the version to ClassDef(TGeoVolume,7).
   Do not try to write objects with the current class definition,
   the files will not be readable.

Warning in <TStreamerInfo::CompareContent>: The following data member of
the in-memory layout version 6 of class 'TGeoVolume' is missing from 
the on-file layout version 6:
   TGeoExtension* fUserExtension; //
Warning in <TStreamerInfo::BuildCheck>: 
   The StreamerInfo of class TGeoNode read from file /build/yana/DD4HEP/CMSSW_10_4_X_2018-11-11-2300/src/./cmsDD4HepGeom.root
   has the same version (=2) as the active class but a different checksum.
   You should update the version to ClassDef(TGeoNode,3).
   Do not try to write objects with the current class definition,
   the files will not be readable.

Warning in <TStreamerInfo::CompareContent>: The following data member of
the in-memory layout version 2 of class 'TGeoNode' is missing from 
the on-file layout version 2:
   TGeoExtension* fUserExtension; //
Warning in <TClass::Init>: no dictionary for class dd4hep::VolumeExtension is available
Warning in <TClass::Init>: no dictionary for class dd4hep::Region is available
Warning in <TClass::Init>: no dictionary for class dd4hep::Handle<dd4hep::RegionObject> is available
Warning in <TClass::Init>: no dictionary for class dd4hep::RegionObject is available
Warning in <TClass::Init>: no dictionary for class dd4hep::NamedObject is available
Warning in <TClass::Init>: no dictionary for class dd4hep::LimitSet is available
Warning in <TClass::Init>: no dictionary for class dd4hep::Handle<dd4hep::LimitSetObject> is available
Warning in <TClass::Init>: no dictionary for class dd4hep::LimitSetObject is available
Warning in <TClass::Init>: no dictionary for class dd4hep::VisAttr is available
Warning in <TClass::Init>: no dictionary for class dd4hep::Handle<dd4hep::VisAttrObject> is available
Warning in <TClass::Init>: no dictionary for class dd4hep::VisAttrObject is available
Warning in <TClass::Init>: no dictionary for class dd4hep::Handle<dd4hep::NamedObject> is available
Warning in <TClass::Init>: no dictionary for class dd4hep::PlacedVolumeExtension is available
TFile**		/build/yana/DD4HEP/CMSSW_10_4_X_2018-11-11-2300/src/./cmsDD4HepGeom.root	
 TFile*		/build/yana/DD4HEP/CMSSW_10_4_X_2018-11-11-2300/src/./cmsDD4HepGeom.root	
  KEY: TGeoManager	default;1	Detector Geometry
  KEY: TNamed	CMSSW_VERSION;1	CMSSW_10_4_X_2018-11-11-2300
  KEY: TNamed	tag;1	unknown
Warning in <TClass::Init>: no dictionary for class dd4hep::PlacedVolumeExtension::VolIDs is available
Info: Geometry table file: cmsDD4HepGeom.root
Error: Failed to find simulation geomtery file. Please set the file path with --sim-geom-file option.

@smuzaffar
Copy link
Contributor

@ianna , yes it could be. Do you get this warning if you use CMSSW_10_4_X_2018-11-09-1100 IB (where we have previous version of dd4hep)?

@ianna
Copy link

ianna commented Nov 12, 2018

@smuzaffar - only if I try to read a root file produced with CMSSW_10_4_X_2018-11-11-2300

@smuzaffar
Copy link
Contributor

Looks like new dictionaries are added in new dd4hep which are saved in the root file that is why when reading it with an older version of dd4hep we get this warning. I guess you will not get the warning if you read it back in the same release .... right?

@ianna
Copy link

ianna commented Nov 12, 2018

nope, the warnings are present in the CMSSW_10_4_X_2018-11-11-2300 as well.

@smuzaffar
Copy link
Contributor

@ Dr15Jones any idea what could be wrong here?
@ianna , would you suggest to revert dd4hep change before we understand the issue. We are building 10.4.0.pre2 today. If this dd4hep update is breaking things then we should revert it.

@davidlange6
Copy link
Contributor

davidlange6 commented Nov 12, 2018 via email

@smuzaffar
Copy link
Contributor

yes but if I understand correctly @ianna is getting warnings with newer dd4ep too.

@fabiocos
Copy link
Contributor

@ianna @smuzaffar could you please clarify whether the problem is on the new files as well? I have started to build the externals for CMSSW_10_4_0_pre2, in case I should stop, revert the dd4hep and restart...

@smuzaffar
Copy link
Contributor

@fabiocos , do not stop the external builds for pre2. Even in case we have to revert dd4hep then it is just one external which only cmssw uses.

@fabiocos
Copy link
Contributor

ok, after everything is built we may restart the build rebuilding just that, right?
It is not directly affecting production, it si mostly for @ianna 's work, but still it is not nice to have it broken a priori

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants