New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated dd4hep to tip of branch master #4487
Updated dd4hep to tip of branch master #4487
Conversation
A new Pull Request was created by @gudrutis (Zygimantas Matonis) for branch IB/CMSSW_10_4_X/gcc700. @cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks. |
@gudrutis - Thanks! |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
+externals |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_4_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@smuzaffar - is the following warning/error due to the update?
|
@ianna , yes it could be. Do you get this warning if you use CMSSW_10_4_X_2018-11-09-1100 IB (where we have previous version of dd4hep)? |
@smuzaffar - only if I try to read a root file produced with CMSSW_10_4_X_2018-11-11-2300 |
Looks like new dictionaries are added in new dd4hep which are saved in the root file that is why when reading it with an older version of dd4hep we get this warning. I guess you will not get the warning if you read it back in the same release .... right? |
nope, the warnings are present in the CMSSW_10_4_X_2018-11-11-2300 as well. |
@ Dr15Jones any idea what could be wrong here? |
this would be a "normal" behavior right? the old dd4hep build would not be expected to know about the newer dd4hep changes or be able to deal properly with them.
… On Nov 12, 2018, at 12:13 PM, Malik Shahzad Muzaffar ***@***.***> wrote:
Looks like new dictionaries are added in new dd4hep which are saved in the root file that is why when reading it with an older version of dd4hep we get this warning. I guess you will not get the warning if you read it back in the same release .... right?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
yes but if I understand correctly @ianna is getting warnings with newer dd4ep too. |
@ianna @smuzaffar could you please clarify whether the problem is on the new files as well? I have started to build the externals for CMSSW_10_4_0_pre2, in case I should stop, revert the dd4hep and restart... |
@fabiocos , do not stop the external builds for pre2. Even in case we have to revert dd4hep then it is just one external which only cmssw uses. |
ok, after everything is built we may restart the build rebuilding just that, right? |
No description provided.