[10_2_X] Update data-RecoBTag-Combined.spec

[mrodozov]

Backport of #4540

[cmsbuild]

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_10_2_X/gcc700.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

• Backported from Update RecoBTag-Combined to new tag #4540

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31978/console

[cmsbuild]

+1
Tested at: 5cfe7e8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4550/31978/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4550/31978/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 3007299
• DQMHistoTests: Total failures: 4
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3007105
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 129 log files, 14 edm output root files, 31 DQM output files

[slava77]

Reco comparison results: 0 differences found in the comparisons

this confirms that this external can be merged by itself before the cms-sw/cmssw#25370 is merged.

[cmsbuild]

The tests are being triggered in jenkins.
Using cmssw from cms-sw/cmssw#25370
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31994/console

[cmsbuild]

+1
Tested at: 5cfe7e8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25370/31994/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

The tests are being triggered in jenkins.
Using cmssw from cms-sw/cmssw#25370
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32010/console

[cmsbuild]

+1
Tested at: 5cfe7e8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25370/32010/summary.html

[cmsbuild]

Comparison job queued.

[smuzaffar]

+externals

this resolves #4537

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_2_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

The tests are being triggered in jenkins.
Using cmssw from cms-sw/cmssw#25370
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32046/console

[cmsbuild]

+1
Tested at: 5cfe7e8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25370/32046/summary.html

[cmsbuild]

Comparison job queued.

[smuzaffar]

+externals

[fabiocos]

@andrzejnovak @slava77 @perrotta this external update is needed by cms-sw/cmssw#25370 , that is not yet ready to be merged. As 10_2_9 should start today, is this integration causing issues if not matched to its CMSSW counterpart? I see in https://github.com/cms-data/RecoBTag-Combined/pull/19/files that some files are removed and a few slightly modified, but this might change the behaviour, am I correct?

[slava77]

@fabiocos
tests completed in #4550 (comment)
show that this external can be integrated by itself.

[fabiocos]

@slava77 sorry to be pedantic, is this test supposed to catch the changes induced by these data files? You answer would imply it is, they should appear in miniAOD output, am I correct? In such a case likely workflow 136.85 in the matrix should catch that? Where are these changes supposed to show an effect otherwise?

[fabiocos]

ok, you comment

"jenkins tests pass and comparisons with the baseline show changes only in slimmedJetsAK8 jet tags in an expected way: new tags are added and the existing ones are unchanged"...

[slava77]

ok, you comment

"jenkins tests pass and comparisons with the baseline show changes only in slimmedJetsAK8 jet tags in an expected way: new tags are added and the existing ones are unchanged"...

Sorry, I'm lost.
I was responding to

@andrzejnovak @slava77 @perrotta this external update is needed by cms-sw/cmssw#25370 , that is not yet ready to be merged. As 10_2_9 should start today, is this integration causing issues if not matched to its CMSSW counterpart?

which I read as "can we integrate this data PR without cms-sw/cmssw#25370?"
My response is that by itself this data PR can be integrated and will not introduce any differences.