Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.6.X] updated config tag V05-08-07 #4748

Merged
merged 1 commit into from Mar 4, 2019

Conversation

smuzaffar
Copy link
Contributor

This fixes the cxxmodule build rules.

This fixes the cxxmodule build rules.
@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2019

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_10_6_X/gcc700.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2019

-1

Tested at: e9829e9

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4748/33392/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test test_PixelBaryCentreTool had ERRORS
---> test test_MpsWorkFlow had ERRORS
---> test test-data-file-deletion had ERRORS

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2019

Comparison job queued.

@smuzaffar
Copy link
Contributor Author

smuzaffar commented Mar 4, 2019

unit tests failed as PR tests were run to build full CMSSW release. Some unit tests does not build if directly run from release area. See PRs
cms-sw/cmssw#26060
cms-sw/cmssw#26059

cms-bot is updated to set CMSSW_RELEASE_BASE for PR tests if full release mode is used.

@smuzaffar smuzaffar merged commit 6f2573a into IB/CMSSW_10_6_X/gcc700 Mar 4, 2019
@smuzaffar smuzaffar deleted the smuzaffar-patch-2 branch March 5, 2019 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants