Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pyquen reintegration as external #4790

Merged
merged 6 commits into from Apr 2, 2019
Merged

Pyquen reintegration as external #4790

merged 6 commits into from Apr 2, 2019

Conversation

wouf
Copy link
Contributor

@wouf wouf commented Mar 20, 2019

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wouf for branch IB/CMSSW_10_6_X/gcc700.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@smuzaffar
Copy link
Contributor

assign generators

@cmsbuild
Copy link
Contributor

New categories assigned: generators

@alberto-sanchez,@perrozzi,@efeyazgan,@qliphy you have been requested to review this Pull request/Issue and eventually sign? Thanks

@wouf wouf mentioned this pull request Mar 21, 2019
Merged
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 21, 2019 •
edited

The tests are being triggered in jenkins.
Using cmssw from cms-sw/cmssw#26226
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33704/console
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33705/console
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33711/console

@cmsbuild
Copy link
Contributor

+1
Tested at: 748705d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26226/33711/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26226/33711/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-26226/301.0_Pyquen_DiJet_pt80to120_2760GeV+Pyquen_DiJet_pt80to120_2760GeV+DIGIHIMIX+RECOHIMIX+HARVESTHI2018PPRECO

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3114829
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3114631
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 22, 2019 •
edited

The tests are being triggered in jenkins.
Using cmssw from cms-sw/cmssw#26226
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33724/console
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33791/console

@cmsbuild
Copy link
Contributor

+1
Tested at: 748705d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26226/33724/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26226/33724/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-26226/301.0_Pyquen_DiJet_pt80to120_2760GeV+Pyquen_DiJet_pt80to120_2760GeV+DIGIHIMIX+RECOHIMIX+HARVESTHI2018PPRECO

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3114829
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3114631
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@cmsbuild
Copy link
Contributor

Pull request #4790 was updated.

@wouf
Copy link
Contributor Author

wouf commented Mar 27, 2019

Thanks, we can continue.

@smuzaffar
Copy link
Contributor

unhold

@cmsbuild cmsbuild removed the hold label Mar 27, 2019
@cmsbuild
Copy link
Contributor

+1
Tested at: 963e6b1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26226/33791/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26226/33791/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-26226/301.0_Pyquen_DiJet_pt80to120_2760GeV+Pyquen_DiJet_pt80to120_2760GeV+DIGIHIMIX+RECOHIMIX+HARVESTHI2018PPRECO

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3114829
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3114631
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Apr 2, 2019

@alberto-sanchez this needs GEN signature as well, as it goes together with cms-sw/cmssw#26226

@alberto-sanchez
Copy link
Member

+1

@fabiocos
Copy link
Contributor

fabiocos commented Apr 2, 2019

+1

@fabiocos
Copy link
Contributor

fabiocos commented Apr 2, 2019

merge

@cmsbuild cmsbuild merged commit 95e43bb into cms-sw:IB/CMSSW_10_6_X/gcc700 Apr 2, 2019
@smuzaffar
Copy link
Contributor

+externals
just to keep the signatures clean

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2019

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_6_X/gcc700 IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available externals-approved fully-signed generators-approved orp-approved tests-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wouf @cmsbuild @smuzaffar @fabiocos @alberto-sanchez