Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update openloops-2.0.b to openloops-2.0.0 #4796

Merged

Conversation

SiewYan
Copy link
Contributor

@SiewYan SiewYan commented Mar 21, 2019

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @SiewYan (SiewYan) for branch IB/CMSSW_10_6_X/gcc700.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@smuzaffar
Copy link
Contributor

@SiewYan , for OpenLoops 2.0.b we have some optimization done by @davidlange6 and Philipp Maierhoefer

cms-externals/openloops@5141c0e
cms-externals/openloops@5141c0e

Looks like these are missing in 2.0.0. Do we not need them?

@SiewYan
Copy link
Contributor Author

SiewYan commented Mar 25, 2019

Hi @smuzaffar , yes, please include the optimization. Thanks.

@smuzaffar
Copy link
Contributor

@mrodozov , can you please get Openloop 2.0.0 tar file and create cms/2.0.0 branch under cms-externals/openloops and include our patches on top of it?

@mrodozov
Copy link
Contributor

mrodozov commented Mar 25, 2019

@SiewYan , I've added the the tar as initial commit on this branch https://github.com/cms-externals/openloops/tree/cms/v2.0.0 and this commit cms-externals/openloops@5141c0e but couldn't add this one cms-externals/openloops@a0fd889
as the structure of the code changed.

@SiewYan
Copy link
Contributor Author

SiewYan commented Mar 25, 2019

Hi @mrodozov thanks for creating the commit. I am adding previous committer @davidlange6 , @davidlange6 could you comment on the patch cms-externals/openloops@a0fd889 is necessary for new openloop 2.0.0? cc @GurpreetSinghChahal

@davidlange6
Copy link
Contributor

davidlange6 commented Mar 25, 2019 via email

@GurpreetSinghChahal
Copy link

Hi @davidlange6, all: thanks!

Let me add @jonaslindert (OpenLoops author). Jonas, a few changes were included via [1] and [2] while integrating OpenLoops 2.0.b in CMS software last year. Please suggest us if we still need those updates in OpenLoops 2.0.

@davidlange6: Could you please remind me why these updates were suggested while integrating OpenLoops 2.0.b in CMS software whereas standalone OpenLoops 2.0.b was working without these updates (afaik). Thanks!

[1]: optimize the factorial function
[2]: Avoid Collier initialisation in EW renorm with every integral call

@jonaslindert
Copy link

Hi @GurpreetSinghChahal, @davidlange6,

right. There have been structural changes in the code so [2] can not directly be applied anymore.
I will provide a corresponding patch for OpenLoops 2.0.0 in due time and we will incorporate that patch into any future version of OpenLoops. [1] on the other hand can directly be applied. We are reluctant to apply [1] directly in OpenLoops as this concerns the third-party tool COLLIER. However, we notified the authors of COLLIER about this issue.

cheers,
Jonas

@davidlange6
Copy link
Contributor

davidlange6 commented Mar 26, 2019 via email

@alberto-sanchez
Copy link
Member

process libraries seems missing. That should included in the cms version

@jonaslindert
Copy link

Hi,

here you find a patch equivalent to [2] linked above. Future versions of OpenLoops will always include this:
https://gitlab.com/openloops/OpenLoops/commit/8ff8f52fe6e0f9f4f3f666b0d89279da64554fc3

cheers,
Jonas

@cmsbuild
Copy link
Contributor

Pull request #4796 was updated.

@SiewYan
Copy link
Contributor Author

SiewYan commented Mar 28, 2019

@jonaslindert thanks for the patch. thanks @davidlange6 for the clarification. @mrodozov could you proceed with the patching:

https://gitlab.com/openloops/OpenLoops/commit/8ff8f52fe6e0f9f4f3f666b0d89279da64554fc3

Thanks.

@cmsbuild
Copy link
Contributor

Pull request #4796 was updated.

@mrodozov
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 28, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33826/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4796/34042/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3140495
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3140297
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

SiewYan added a commit to SiewYan/cmsdist that referenced this pull request Apr 9, 2019
Propagating changes in cms-sw#4796 
1.) Include proclib
2.) Process libraries generation
3.) changes openloops source by imitating gitlab tag hash
SiewYan added a commit to SiewYan/cmsdist that referenced this pull request Apr 9, 2019
Propagating changes in cms-sw#4796 
1.) Include proclib
2.) Process libraries generation
3.) changes openloops source by imitating gitlab tag hash
SiewYan added a commit to SiewYan/cmsdist that referenced this pull request Apr 9, 2019
Propagating changes in cms-sw#4796 
1.) Include proclib
2.) Process libraries generation
3.) changes openloops source by imitating gitlab tag hash
@qliphy
Copy link
Contributor

qliphy commented Apr 12, 2019

@fabiocos @mrodozov Can we merge this now? This is needed for the next version of Sherpa, i.e. 226

@fabiocos
Copy link
Contributor

please test workflow 534.0,536.0

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 12, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34173/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4796/34173/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-4796/534.0_sherpa_ZtoEE_0j_OpenLoops_13TeV_MASTER+sherpa_ZtoEE_0j_OpenLoops_13TeV_MASTER+HARVESTGEN
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-4796/536.0_sherpa_ttbar_2j_MENLOPS_13TeV_MASTER+sherpa_ttbar_2j_MENLOPS_13TeV_MASTER+HARVESTGEN

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3140495
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3140297
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@fabiocos
Copy link
Contributor

+1

the needed patches have been applied

@fabiocos
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 3e8f65f into cms-sw:IB/CMSSW_10_6_X/gcc700 Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants