Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable geant4 and example/ddcms for dd4hep #4820

Merged
merged 5 commits into from Apr 1, 2019

Conversation

smuzaffar
Copy link
Contributor

We now build DD4Hep with Geant4 enabled. This change does the following

  • build normal DD4Hep with out Geant4
  • Build DDG4 part of DD4Hep as static libraries. This is done to avoid loading of Geant4 shared libraries via DDG4.so if this end up as dependency on big simulation plugin in CMSSW (which only links against static geant4).
  • Enabled building of DDCMS example. In past we had added a dd4hep-cms tool but the libDDCMS.so was not actually build. One has to explicitly build examples/DDCMS to get it generated.

This should resolve cms-sw/cmssw#26242
FYI @ianna

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_10_6_X/gcc700.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@smuzaffar
Copy link
Contributor Author

@ianna, please note that when we enable Geant4 then it generates following archive libs. For now I have only added DDG4 in the dd4hep-geant4 toolfile. Let me know if if any of other libs need to go in the tool definition

DDG4
DDG4Legacy
DDG4Plugins
DDG4Python

@ianna
Copy link

ianna commented Mar 28, 2019

@smuzaffar - thanks, I'll test it and let you know

@cmsbuild
Copy link
Contributor

Pull request #4820 was updated.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 29, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33851/console

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 29, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33860/console

@cmsbuild
Copy link
Contributor

Pull request #4820 was updated.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4820/33860/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3134059
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3133861
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@smuzaffar
Copy link
Contributor Author

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_6_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar merged commit 7ebca30 into IB/CMSSW_10_6_X/gcc700 Apr 1, 2019
@fabiocos
Copy link
Contributor

fabiocos commented Apr 2, 2019

@smuzaffar @ianna after merging this PR I see in the IB two DetectorDescription/DDCMS unit tests failing, I do not see what else could be responsible for this:

----- Begin Fatal Exception 02-Apr-2019 04:10:14 CEST-----------------------
An exception of category 'StdException' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'p'
   [2] Calling method for module DDCMSDetector/'test'
   [3] Using EventSetup component DDDetectorESProducer/'' to make data DDDetector/'CMS' in record DetectorDescriptionRcd
Exception Message:
A std::exception was thrown.
dd4hep: Failed to locate plugin to interprete files of type "DDDefinition" - no factory:DDDefinition_XML_reader. 		No factory with name Create(DDDefinition_XML_reader) for type DDDefinition_XML_reader found.
		Please check library load path and/or plugin factory name.
dd4hep: while parsing /pool/condor/dir_32339/jenkins/workspace/ib-run-qa/CMSSW_10_6_ROOT614_X_2019-04-01-2300/src/DetectorDescription/DDCMS/data/cms-tracker.xml
dd4hep: with plugin:DD4hep_CompactLoader
----- End Fatal Exception -------------------------------------------------

cat << \EOF_TOOLFILE >%i/etc/scram.d/dd4hep-geant4.xml
<tool name="dd4hep-geant4" version="@TOOL_VERSION@">
<lib anme="DDG4-static"/>
<use name="geant4-core"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smuzaffar this seems to cause in recent IBs

gmake[1]: Entering directory '/build/fabiocos/106X/26301/CMSSW_10_6_X_2019-04-01-2300'
****WARNING: Invalid tool geant4-core. Please fix dd4hep-geant4 file.

Should not be geant4core ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @fabiocos for catching this. I have fixed this in #4835

@smuzaffar smuzaffar deleted the dd4hep-g4 branch April 5, 2019 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DD4hep: DDG4 package is missing
4 participants