New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable geant4 and example/ddcms for dd4hep #4820
Conversation
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_10_6_X/gcc700. @cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks. |
@ianna, please note that when we enable Geant4 then it generates following archive libs. For now I have only added DDG4 in the dd4hep-geant4 toolfile. Let me know if if any of other libs need to go in the tool definition
|
@smuzaffar - thanks, I'll test it and let you know |
Pull request #4820 was updated. |
please test |
The tests are being triggered in jenkins. |
please test |
The tests are being triggered in jenkins. |
Pull request #4820 was updated. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+externals |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_6_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@smuzaffar @ianna after merging this PR I see in the IB two DetectorDescription/DDCMS unit tests failing, I do not see what else could be responsible for this:
|
cat << \EOF_TOOLFILE >%i/etc/scram.d/dd4hep-geant4.xml | ||
<tool name="dd4hep-geant4" version="@TOOL_VERSION@"> | ||
<lib anme="DDG4-static"/> | ||
<use name="geant4-core"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smuzaffar this seems to cause in recent IBs
gmake[1]: Entering directory '/build/fabiocos/106X/26301/CMSSW_10_6_X_2019-04-01-2300'
****WARNING: Invalid tool geant4-core. Please fix dd4hep-geant4 file.
Should not be geant4core ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We now build DD4Hep with Geant4 enabled. This change does the following
This should resolve cms-sw/cmssw#26242
FYI @ianna