Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.6.X] Update RecoBTag-Combined to V01-01-03 #4829

Merged
merged 1 commit into from Apr 4, 2019

Conversation

mrodozov
Copy link
Contributor

Description here: cms-data/RecoBTag-Combined#21

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_10_6_X/gcc700.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@mrodozov mrodozov changed the title Update RecoBTag-Combined to V01-01-03 [10.6.X] Update RecoBTag-Combined to V01-01-03 Mar 29, 2019
@mrodozov
Copy link
Contributor Author

mrodozov commented Mar 29, 2019

Resolves: #4827
Previous update is still open #4752

@mrodozov
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@slava77
Copy link
Contributor

slava77 commented Mar 29, 2019

Resolves #4827
Previous update is still open #4752

ah, good point.
If Once the related CMSSW PR for this one is ready, we'll just proceed with this update and will supersede #4752.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 29, 2019

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#26298
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33853/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4829/33853/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3134059
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3133861
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2019

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#26298
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33877/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26298/33877/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 579 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3139747
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3139536
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@slava77
Copy link
Contributor

slava77 commented Apr 4, 2019

I have recently signed the CMSSW PR (cms-sw/cmssw#26298) that needs this cmsdist PR.
Please proceed with merging when convenient.

@fabiocos
Copy link
Contributor

fabiocos commented Apr 4, 2019

+1

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2019

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_6_X/gcc700 IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 2393ac4 into IB/CMSSW_10_6_X/gcc700 Apr 4, 2019
@smuzaffar smuzaffar deleted the update-reco-btag-cmb-010103 branch April 5, 2019 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants