New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update externals for ppc64 build #4838
Conversation
A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_10_6_X/gcc700. @cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks. |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
vecgeom.spec
Outdated
@@ -5,15 +5,20 @@ BuildRequires: cmake gmake | |||
|
|||
%define isamd64 %(case %{cmsplatf} in (*amd64*) echo 1 ;; (*) echo 0 ;; esac) | |||
%define isaarch64 %(case %{cmsplatf} in (*_aarch64_*) echo 1 ;; (*) echo 0 ;; esac) | |||
%define isppc64 %(case %{cmsplatf} in (*_ppc64le_*) echo 1 ;; (*) echo 0 ;; esac) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mrodozov , can you please update the PR to use the following
%ifarch ppc64le
%ifnarch ppc64le
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed it everywhere and removed some defines
Pull request #4838 was updated. |
Pull request #4838 was updated. |
Pull request #4838 was updated. |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+externals |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_6_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@@ -4,12 +4,20 @@ Source: git+https://stash.desy.de/scm/geneva/geneva-public.git?obj=master/%{real | |||
|
|||
BuildRequires: cmake gmake | |||
|
|||
Requires: python py2-setuptools py2-numpy gsl boost lhapdf hepmc openloops pythia8 | |||
Requires: python py2-setuptools py2-numpy gsl boost lhapdf hepmc pythia8 | |||
%ifnarch ppc64le |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure whether this will allow us to have a fully working version, but I understand that oterwise the build cannot proceed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not build openloops for non-amd64 archs. We will change the above line to be %ifarch x86_64
to make it consistent with sherpa, herwigpp and cmssw-tool-conf.
https://github.com/cms-sw/cmsdist/blob/8a4f8beb18943981d26b0b72b295e923a9b6223c/sherpa.spec#L12:L16
https://github.com/cms-sw/cmsdist/blob/ab6cf5ba4201f09658ff066c7d840f5a5e065023/herwigpp.spec#L16:L18
https://github.com/cms-sw/cmsdist/blob/95e43bbbf2ca2530091b8e44b19b4d4fa8aa1539/cmssw-tool-conf.spec#L173:L178
+1 |
Changes needed to build all externals on PowerPC (used the techlab-ppc64le-winstron-01 machine)
Only openloops remains to be fixed (failing with multiple fortran complains) and tfcompile (fails with similar complain to this one https://sft.its.cern.ch/jira/browse/ROOT-4385?focusedCommentId=24479&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel)