Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DDG4 headers to dd4hep include #4855

Merged
merged 1 commit into from Apr 8, 2019

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented Apr 8, 2019

The least evil way to install the includes

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2019

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_10_6_X/gcc700.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@mrodozov
Copy link
Contributor Author

mrodozov commented Apr 8, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34053/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4855/34053/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3140495
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3140297
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@smuzaffar smuzaffar merged commit 31fe919 into IB/CMSSW_10_6_X/gcc700 Apr 8, 2019
@smuzaffar smuzaffar deleted the update-dd4hep-includes branch April 11, 2019 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants