[data] PhysicsTools-NanoAOD to tag 01-00-04

[mrodozov]

Resolves: #4936

[cmsbuild]

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_10_6_X/gcc700.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

[mrodozov]

please test with cms-data/PhysicsTools-NanoAOD#5

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-data/PhysicsTools-NanoAOD#5
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/51/console Started: 2019/05/07 14:16

[cmsbuild]

+1
Tested at: b224f20
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5f0c85/51/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5f0c85/51/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3211964
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211759
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#26703,cms-sw/cmssw#26672
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/93/console Started: 2019/05/08 20:26
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/98/console Started: 2019/05/08 21:51

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#26703,cms-sw/cmssw#26672,cms-data/PhysicsTools-NanoAOD#5
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/115/console Started: 2019/05/09 09:50

[cmsbuild]

+1
Tested at: b224f20
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7e01a1/115/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
fcadd99
f92240c
359c364
bc49b4d
9428830
5dbd085
1992b44
cde04d8
cb9e4a2
5fbcce2
8376baf
fd02fcb
5d55f20
7f7dbfc
15486b8
18e2b78
1b19348
3a71510
7575f73
3cfb786
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4937/115/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4937/115/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7e01a1/125/summary.html

Comparison Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 294 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3211957
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211748
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.639 KiB( 32 files compared)
• DQMHistoSizes: changed ( 1325.7 ): -0.639 KiB Physics/NanoAODDQM
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[fabiocos]

@mrodozov @smuzaffar concerning this conflict, if I understand the logic of this file both externals should be taken now, am I correct?

[fabiocos]

I would like to merge this asap, so as to start possibly building the external tools for 10_6_0

[cmsbuild]

Pull request #4937 was updated.

[smuzaffar]

+externals
@fabiocos , this is ready to be merged. Tests signature got reset due to merge conflicts. there is no need to re-run the tests

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/170/console Started: 2019/05/12 16:57

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_6_X/gcc700 IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[smuzaffar]

@fabiocos , this is now merge. I see that this was tested with two cmssw PRs
cms-sw/cmssw#26703
cms-sw/cmssw#26672
while only one of these is merged in cmssw.

[peruzzim]

could you please update it also for 10_2_X? it is needed for cms-sw/cmssw#26769

[smuzaffar]

@peruzzim , #4967 is for 10.2.X

[peruzzim]

thanks