updated sqlalchemy to version 1.3.4 #5023
Conversation
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
@ggovi , there are two security vulnerabilities in the SQLAlchemy version we are using and suggestion from github was to move to 1.3.3 or above. This PR includes SQLAlchemy 1.3.4 + our patches. Are there are tests in cmssw which use SQLAlchemy to make sure it works as expected? |
|
@smuzaffar |
|
thanks @ggovi . I created cms-sw/cmssw#27142 to make sure that cmssw unit tests are run when SQLAlchemy is updated. |
|
The tests are being triggered in jenkins. |
|
ping bot |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: |
|
Comparison job queued. |
|
+externals |
cmsbuild
added
externals-approved
fully-signed
and removed
externals-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_0_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
Comparison is ready Comparison Summary:
|
This PR's also how SQLAlchemy is built.