Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated dd4hep to tip of branch master #5140

Merged

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented Aug 7, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2019

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_11_0_X/gcc700.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@mrodozov
Copy link
Contributor Author

mrodozov commented Aug 7, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1873/console Started: 2019/08/07 17:37

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2019

-1

Tested at: b1bc28c

  • Build:

I found compilation error when building:

CMakeLists.txt:129 (include)


-- Configuring incomplete, errors occurred!
See also "/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc700/external/dd4hep/v01-10x-cms/build/CMakeFiles/CMakeOutput.log".
error: Bad exit status from /build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.TdUEZj (%build)


RPM build errors:
Bad exit status from /build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.TdUEZj (%build)



You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c7eee/1873/summary.html

@mrodozov
Copy link
Contributor Author

mrodozov commented Aug 8, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1899/console Started: 2019/08/08 11:07

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2019

Pull request #5140 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2019

-1

Tested at: f191791

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c7eee/1899/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test testDD4hepFilteredView had ERRORS
---> test testDD4hepCompactView had ERRORS
---> test testDD4hepExpandedView had ERRORS
---> test DetectorDescriptionDDCMSTestDriver had ERRORS
---> test DD4hepGeometryTestDriver had ERRORS

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2019

Comparison job queued.

@smuzaffar
Copy link
Contributor

@ianna looks like we need to update DD4Hep unit tests to go with this update. If neded @mrodozov can provide you a local build of this on cmsdev so that you can fix these unit tests.

@mrodozov
Copy link
Contributor Author

mrodozov commented Aug 8, 2019

on cmsdev20

scram p CMSSW_11_0_X_2019-08-08-1100
cp /build/mrodozov/build_dd4hep/slc7_amd64_gcc700/external/dd4hep-toolfile/1.0-cms/etc/scram.d/dd4hep* CMSSW_11_0_X_2019-08-08-1100/config/toolbox/slc7_amd64_gcc700/tools/selected/
cd CMSSW_11_0_X_2019-08-08-1100 ; cmsenv ; scram setup ;
git-cms-addpkg DetectorDescription/DDCMS
scram b -j 16 
scram b runtests_testDD4hepCompactView

just tried it, should work

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c7eee/1899/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 2715989
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2715659
  • DQMHistoTests: Total skipped: 329
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@ianna
Copy link

ianna commented Aug 8, 2019 via email

@smuzaffar
Copy link
Contributor

please test with cms-sw/cmssw#27728

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2019

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#27728
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1912/console Started: 2019/08/08 16:26

@smuzaffar
Copy link
Contributor

thanks @ianna , tests are running now

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ff32a0/1912/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 2715989
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2715659
  • DQMHistoTests: Total skipped: 329
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@smuzaffar
Copy link
Contributor

+externals
@fabiocos , this along with cms-sw/cmssw#27728 are ready to go in.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2019

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_0_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Aug 9, 2019

@smuzaffar @ianna I'll merge this and the parallel CMSSW update into the next IB

@fabiocos
Copy link
Contributor

fabiocos commented Aug 9, 2019

+1

@cmsbuild cmsbuild merged commit 2327f18 into cms-sw:IB/CMSSW_11_0_X/gcc700 Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants