Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PYLint] fixed encoding issue with pylint 2.4.2 #5267

Merged
merged 2 commits into from Oct 8, 2019

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Oct 8, 2019

pylint 2.4.2 failed to build for python3 due to encding issues [a]. We patch it to avoid ignore special characters in README.rst file.

[a]

      File "/build/cmsbld/jenkins/workspace/build-any-ib/w/tmp/pip-2z0c36hw-build/setup.py", line 60, in <module>
        long_description = stream.read()
      File "/build/cmsbld/jenkins/workspace/build-any-ib/w/slc7_amd64_gcc820/external/python3/3.6.4-pafccj/lib/python3.6/encodings/ascii.py", line 26, in decode
        return codecs.ascii_decode(input, self.errors)[0]
    UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 4020: ordinal not in range(128)

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2019

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_11_0_X/master.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2019

Pull request #5267 was updated.

@smuzaffar
Copy link
Contributor Author

please test for slc7_aarch64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2835/console Started: 2019/10/08 13:13
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2836/console Started: 2019/10/08 18:39

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2019

Comparison job queued.

@smuzaffar
Copy link
Contributor Author

+externals

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2019

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d7400a/2836/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2961052
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2960710
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@smuzaffar smuzaffar deleted the pylint-242-encoding branch October 10, 2019 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants