New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Py3 Changes for frontier py client and py2-sqlalchemy #5273
Py3 Changes for frontier py client and py2-sqlalchemy #5273
Conversation
A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_11_0_X/master. @cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks. |
@mrodozov - I don't believe the sqalc patch will work on python2 - you need to check the python version.. |
ah - but that patch explains my current error... |
I'm fixing the version check part and then it will work |
Pull request #5273 was updated. |
please test |
The tests are being triggered in jenkins. |
-1 Tested at: 96febf9 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test RunInfoStart_O2O_test had ERRORS |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
sys needs to be imported before used
please test |
The tests are being triggered in jenkins. |
-1 Tested at: 2061cbe You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test SiStripDCS_O2O_test had ERRORS |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+externals |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
Changes for frontier client and sqlalchemy frontier connector