Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo: CLIENT vs. CLINET #5479

Merged
merged 2 commits into from Jan 22, 2020
Merged

Conversation

belforte
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @belforte (Stefano Belforte) for branch IB/CMSSW_11_1_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@belforte
Copy link
Contributor Author

after I did this, I noticed that the typo appears in several other files. So maybe there's some procedure which writes them. In any case, take this simply as a pointer to the thing, not something to merge. And up to you if you want to make it easier to read by changing the name

@cmsbuild
Copy link
Contributor

Pull request #5479 was updated.

@smuzaffar
Copy link
Contributor

please test
thanks @belforte .I have fixed the remaining one.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 22, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4305/console Started: 2020/01/22 08:25

@cmsbuild
Copy link
Contributor

+1
Tested at: 75c5b02
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f23216/4305/summary.html
CMSSW: CMSSW_11_1_X_2020-01-21-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f23216/4305/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2697090
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2696743
  • DQMHistoTests: Total skipped: 346
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@smuzaffar
Copy link
Contributor

+externals
this is independent of cmssw.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@belforte belforte deleted the patch-2 branch January 22, 2020 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants