Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.6.X] Use OpenBlas instead of GSL Blas implementation #5551

Merged
merged 2 commits into from Feb 20, 2020

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented Feb 14, 2020

please test
backport of #5540

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 14, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4663/console Started: 2020/02/14 11:33

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 14, 2020

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_10_6_X/gcc820.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Tested at: 358e523

  • Build:

I found compilation error when building:

/cvmfs/cms-ib.cern.ch/nweek-02615/slc7_amd64_gcc820/external/gcc/8.2.0-pafccj/include/c++/8.3.1/bits/stl_algo.h: At global scope:
/cvmfs/cms-ib.cern.ch/nweek-02615/slc7_amd64_gcc820/external/gcc/8.2.0-pafccj/include/c++/8.3.1/bits/stl_algo.h:3921:5: warning: '_IIter std::find_if(_IIter, _IIter, _Predicate) [with _IIter = __gnu_cxx::__normal_iterator >; _Predicate = {anonymous}::RPredicateIsSameNamespace]' used but never defined
find_if(_InputIterator __first, _InputIterator __last,
^~~~~~~
ninja: build stopped: subcommand failed.
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.f2T7z4 (%build)


RPM build errors:
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.f2T7z4 (%build)



You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d3e5e0/4663/summary.html

@mrodozov
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 14, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4675/console Started: 2020/02/14 17:08

@cmsbuild
Copy link
Contributor

Pull request #5551 was updated.

@cmsbuild
Copy link
Contributor

+1
Tested at: 6ba2b3a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d3e5e0/4675/summary.html
CMSSW: CMSSW_10_6_X_2020-02-12-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@smuzaffar smuzaffar changed the title [10.6.X] Backport #5540 on 10_6_X_gcc820 [10.6.X] Use OpenBlas instead of GSL Blas implementation Feb 14, 2020
@smuzaffar
Copy link
Contributor

backport of #5540

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d3e5e0/4675/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 44450 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3212324
  • DQMHistoTests: Total failures: 382860
  • DQMHistoTests: Total nulls: 7
  • DQMHistoTests: Total successes: 2829123
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -3.14 KiB( 32 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): 0.786 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 136.85 ): 0.012 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 250202.181 ): -0.303 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): -0.904 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): -2.731 KiB SiStrip/MechanicalView
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

Pull request #5551 was updated.

fix a $ and remove spaces
@mrodozov
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 18, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4724/console Started: 2020/02/18 09:59

@cmsbuild
Copy link
Contributor

Pull request #5551 was updated.

@cmsbuild
Copy link
Contributor

-1

Tested at: 3e8805f

CMSSW: CMSSW_10_6_X_2020-02-17-2300
SCRAM_ARCH: slc7_amd64_gcc700
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d3e5e0/4724/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test testConnectionPool had ERRORS
---> test test_PixelBaryCentreTool had ERRORS

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d3e5e0/4724/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3212324
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211989
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_6_X/gcc700 IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 67104f0 into cms-sw:IB/CMSSW_10_6_X/gcc700 Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants