Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix undefined spec variable for CUDA on ARM #5610

Merged
merged 1 commit into from Feb 28, 2020
Merged

Fix undefined spec variable for CUDA on ARM #5610

merged 1 commit into from Feb 28, 2020

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Feb 27, 2020

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for branch IB/CMSSW_11_1_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 27, 2020

@cmsbuild, please test for slc7_aarch64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 27, 2020 •
edited

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

+1
Tested at: 4e490e4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-156fef/4924/summary.html
CMSSW: CMSSW_11_1_X_2020-02-27-1100
SCRAM_ARCH: slc7_aarch64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@mrodozov
Copy link
Contributor

please test for slc7_aarch64_gcc820

@mrodozov
Copy link
Contributor

comparison job failed again

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 28, 2020 •
edited

The tests are being triggered in jenkins.
Test Parameters:

@silviodonato
Copy link
Contributor

@mrodozov Andrea ran "please test for slc7_aarch64_gcc820" last night, and the test was ok. I would merge this PR in the next IB. Do you have some special reason for running again the tests?

@mrodozov
Copy link
Contributor

mrodozov commented Feb 28, 2020 •
edited

I was going to ask you to get this in the IB, yes, the test will keep running regardless. Yes, the reason was to see if the comparison jon will fail again as we have trouble with the comparison jobs for ROOT6 IBs and now also for this ...

@mrodozov
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_1_X/master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@silviodonato
Copy link
Contributor

merge

@silviodonato silviodonato merged commit 39476ac into cms-sw:IB/CMSSW_11_1_X/master Feb 28, 2020
@cmsbuild
Copy link
Contributor

+1
Tested at: 4e490e4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-156fef/4926/summary.html
CMSSW: CMSSW_11_1_X_2020-02-27-2300
SCRAM_ARCH: slc7_aarch64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@fwyzard fwyzard deleted the fix_undefined_spec_variable_for_CUDA_on_ARM branch April 16, 2020 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending externals-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fwyzard @cmsbuild @mrodozov @silviodonato