Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Herwig7 from 7.1.4 to 7.2.0 #5765

Merged

Conversation

Dominic-Stafford
Copy link
Contributor

Upgrade Herwig7 from 7.1.4 to Herwig 7.2.0.
To be tested with: cms-sw/cmssw#29523

Kind regards,
Dominic

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dominic-Stafford for branch IB/CMSSW_11_1_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 20, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#29523
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5791/console Started: 2020/04/20 20:00

@cmsbuild
Copy link
Contributor

+1
Tested at: a8add76
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-693611/5791/summary.html
CMSSW: CMSSW_11_1_X_2020-04-20-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-693611/5791/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2696435
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2696115
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 21, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#29523
Test Parameters:

@cmsbuild
Copy link
Contributor

+1
Tested at: a8add76
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-693611/5799/summary.html
CMSSW: CMSSW_11_1_X_2020-04-20-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-693611/5799/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-693611/511.0_QCD_Pt-30_13TeV_aMCatNLO_herwig7+QCD_Pt-30_13TeV_aMCatNLO_herwig7+HARVESTGEN
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-693611/535.0_TTbar_13TeV_Pow_herwig7+TTbar_13TeV_Pow_herwig7+HARVESTGEN

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2696435
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2696113
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3d5cd5a into cms-sw:IB/CMSSW_11_1_X/master Apr 21, 2020
@davidlange6
Copy link
Contributor

hi @smuzaffar @mrodozov - perhaps the forward port of this did not work for gcc9 or the cxxmodules branch? There are IB errors from the herwig interface.

@smuzaffar
Copy link
Contributor

exactly cms-sw/cmssw#29523 (comment) , this is fixed and I have already started 08h00 IBs for gcc9 and CXXMODULE.

@davidlange6
Copy link
Contributor

cool - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants