New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[crab][dbs] expose dbs python api and examples via crab distribution #5841
Conversation
please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_11_1_X/master. @cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks. |
@belforte and @yuyiguo , once this is merged then
|
Thanks @smuzaffar ! |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+externals |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
@smuzaffar @yuyiguo I see that this was used in last IB since using that [1] I now see the new But I do not see the DBS3 examples around: Do we need to touch crab-*.spec files to trigger a new build ? [1] |
No, no need to touch crab-*.spec. The problem is with finding the lastest version of crab. I have tried to fix it here https://github.com/cms-sw/cmsdist/pull/5847/files . |
@belforte , there are two issues with finding the latest version of crab client
To fix (1), I would suggest to change the crab version naming scheme. As there are no more monthly releases and there is no need to have release candidates so I would suggest that crab client tags in guthub could be either of form 3.3.YYMMDD (e.g. 3.3.200522) or v3.YYMMDD (e.g. v3.200522). To fix (2), I would suggest that we add a numeric suffix for the installation e.g. initial version v3.200522 could be installed as v3.200522.00 and later if you have to update dbs, WMCore or CRABServers tags then the build can be installed in v3.200522.01, v3.200522.02 and so on. So basically every new tag of crabclient will be installed as v3.YYMMDD.00 and every re-build (due to change in WMCore, dbs, CRABServer) will be installed in v3.YYMMDD.NN. This will simplify the crab latest version logic a lot. What do you think? |
thans @smuzaffar very nice ideas. We are not in a hurry. Let me think a bit over this and run the idea in the (small) CRAB group and converge. Will track in a CRAB issue, do no like to add much to a closed PR. |
if a new version of crab client can help in the short tern, I can surely make one in order to test things while sticking with current scheme, right ? I.e. hopefully you do not need the (hard to read) logic in https://github.com/cms-sw/cmsdist/pull/5847/files. Rather I need to ask about (2): who will add the numeric suffix ? where/how will it be visible ? what will crab version return ? |
@belforte , no, currently there is no need to have new tag. my latest changes to get the latest crab version are now in and available under /cvmfs/cms-ib.cern.ch. So dbs/examples should be available now under For (2), the numeric suffix needs to be set/modified by hand. For e.g.
So whenever you need to update crab_client_tag then make sure the suffix is |
I understand. Thanks., |
@smuzaffar I understand the idea, and all in all I like this schema and would like to adopt for crabserver/crabcacge/crabtaskworker as well.
which tells causes versin 3.3.2005 to be checked out from github and built. Looking at crab-build.spec I would unserstand that Line 14 in f6d48c1
so that it uses %{crab_client_tag} instead of %{realversion} ?
Anyhow.. can we give it a try ? What should I do ? |
as suggested in cms-sw#5841 (comment)
dbs
andRestClient
python api via crab distributiondbs/Client/utils
(asexamples
)crab-setup.*sh
scripts to setDBS3_CLIENT_ROOT
pointing to latest crab/dbs distribution