Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend jmalloc to monitor the peak memory usage of each thread (11.1.x) #5853

Merged

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented May 24, 2020

See jemalloc/jemalloc#1176 and jemalloc/jemalloc#1850 for the discussion with the jemalloc development team.

@fwyzard
Copy link
Contributor Author

fwyzard commented May 24, 2020

backport #5852

@cmsbuild
Copy link
Contributor

cmsbuild commented May 24, 2020

A new Pull Request was created by @fwyzard (Andrea Bocci) for branch IB/CMSSW_11_1_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented May 24, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 24, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6549/console Started: 2020/05/24 11:33

@cmsbuild
Copy link
Contributor

+1
Tested at: 1516fd3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-022e59/6549/summary.html
CMSSW: CMSSW_11_1_X_2020-05-23-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-022e59/6549/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780792
  • DQMHistoTests: Total failures: 54
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780688
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 30, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6706/console Started: 2020/05/30 11:12

@cmsbuild
Copy link
Contributor

Pull request #5853 was updated.

@cmsbuild
Copy link
Contributor

+1
Tested at: 76f4f87
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-022e59/6706/summary.html
CMSSW: CMSSW_11_1_X_2020-05-29-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-022e59/6706/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780792
  • DQMHistoTests: Total failures: 50
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780692
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar
Copy link
Contributor

@silviodonato , this can go in 11.1.X . Feel free to merge.

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c4477f4 into cms-sw:IB/CMSSW_11_1_X/master Jun 1, 2020
@fwyzard fwyzard deleted the jemalloc_peak_memory_111x branch July 28, 2020 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants