Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop mcdb and libhepml tools #5886

Merged
merged 1 commit into from Jun 3, 2020
Merged

Conversation

smuzaffar
Copy link
Contributor

As proposed here cms-sw/cmssw#14728, looks like nothing in cmssw is actually using these tools. So we propose to drop these for our software stack.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_11_2_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 29, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#30042
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6685/console Started: 2020/05/29 15:04

@cmsbuild
Copy link
Contributor

+1
Tested at: 848826f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f1b92e/6685/summary.html
CMSSW: CMSSW_11_2_X_2020-05-28-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f1b92e/6685/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780792
  • DQMHistoTests: Total failures: 88
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780654
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@smuzaffar smuzaffar merged commit be962bd into IB/CMSSW_11_2_X/master Jun 3, 2020
@smuzaffar smuzaffar deleted the drop-mcdb-libhepml branch June 3, 2020 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants