Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove jemalloc lib condition #6073

Merged
merged 3 commits into from Jul 16, 2020
Merged

remove jemalloc lib condition #6073

merged 3 commits into from Jul 16, 2020

Conversation

smuzaffar
Copy link
Contributor

We have noticed that cmsRun is not linked against jemalloc library for cc8_amd64_* build. The reason is that the toolfile was only conditionally adding the jemalloc lib for only slc* and fc* archs.

This change should allow to properly link against jemalloc libs if one dependson it.

FYI, @silviodonato @makortel

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_11_2_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

test parameters

@smuzaffar
Copy link
Contributor Author

please test workflow 11634.7,140.5611,20434.0,20434.1 for cc8_amd64_gcc8

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 14, 2020 •
edited

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#30667
Test Parameters:

@cmsbuild cmsbuild mentioned this pull request Jul 14, 2020
Merged
@cmsbuild
Copy link
Contributor

Pull request #6073 was updated.

@cmsbuild
Copy link
Contributor

+1
Tested at: dee60a8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-99f8ef/7947/summary.html
CMSSW: CMSSW_11_2_X_2020-07-13-2300
SCRAM_ARCH: cc8_amd64_gcc8

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

-1

Tested at: d81d1eb

CMSSW: CMSSW_11_2_X_2020-07-14-1100
SCRAM_ARCH: slc7_aarch64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-99f8ef/7950/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

  • RelVals:

When I ran the RelVals I found an error in the following workflows:
11634.7 step3

runTheMatrix-results/11634.7_TTbar_14TeV+TTbar_14TeV_TuneCP5_2021_GenSimFull+DigiFull_2021+RecoFull_trackingMkFit_2021+HARVESTFull_2021/step3_TTbar_14TeV+TTbar_14TeV_TuneCP5_2021_GenSimFull+DigiFull_2021+RecoFull_trackingMkFit_2021+HARVESTFull_2021.log
  • AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 : FAILED - time: date Wed Jul 15 02:05:30 2020-date Wed Jul 15 02:01:04 2020 s - exit: 35584

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@cmsbuild
Copy link
Contributor

-1

Tested at: dee60a8

CMSSW: CMSSW_11_2_X_2020-07-13-2300
SCRAM_ARCH: slc7_ppc64le_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-99f8ef/7948/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

  • AddOn:

I found errors in the following addon tests:

cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run3_mc_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3 --processName=HLTRECO --filein file:RelVal_Raw_GRun_MC.root --fileout file:RelVal_Raw_GRun_MC_HLT_RECO.root : FAILED - time: date Wed Jul 15 02:16:12 2020-date Wed Jul 15 01:55:46 2020 s - exit: 34304
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run3_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Wed Jul 15 02:12:00 2020-date Wed Jul 15 01:56:21 2020 s - exit: 34304

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Pull request #6073 was updated.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-99f8ef/7947/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-99f8ef/20434.1_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D41+RecoFullGlobal_trackingOnly_2026D41+HARVESTFullGlobal_trackingOnly_2026D41

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 48633 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2787429
  • DQMHistoTests: Total failures: 314893
  • DQMHistoTests: Total nulls: 12
  • DQMHistoTests: Total successes: 2472474
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -4.649 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): 0.192 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 10224.0 ): 0.004 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 136.793 ): -0.004 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 136.874 ): -0.020 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 250202.181 ): -0.303 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): -0.910 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): -3.608 KiB SiStrip/MechanicalView
  • Checked 154 log files, 17 edm output root files, 37 DQM output files

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 15, 2020 •
edited

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#30667

@cmsbuild
Copy link
Contributor

+1
Tested at: cf9f26c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-99f8ef/7970/summary.html
CMSSW: CMSSW_11_2_X_2020-07-14-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-99f8ef/7970/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2612943
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2612894
  • DQMHistoTests: Total skipped: 48
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 146 log files, 17 edm output root files, 35 DQM output files

@smuzaffar
Copy link
Contributor Author

+externals

@smuzaffar smuzaffar merged commit 5d7f9a2 into IB/CMSSW_11_2_X/master Jul 16, 2020
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_2_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar deleted the jemalloc-tool-fix branch July 27, 2020 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available externals-approved fully-signed orp-pending requires-external tests-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smuzaffar @cmsbuild