Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3 pip package updates #6187

Merged
merged 9 commits into from Aug 26, 2020

Conversation

davidlange6
Copy link
Contributor

I started to look at what packages can move forward in their python3 version. These are a few of them - mostly Jupyter and matplotlib.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlange6 (David Lange) for branch IB/CMSSW_11_2_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@davidlange6
Copy link
Contributor Author

davidlange6 commented Aug 21, 2020 via email

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 21, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-1

Tested at: 6e4ecc9

  • Build:

I found compilation error when building:

+ DEPS='py2-cffi py2-six '
+ '[' 'py2-cffi py2-six ' '!=' '' ']'
+ echo 'ERROR: Missing dependencies for py2-argon2-cffi (python3) found: py2-cffi py2-six '
ERROR: Missing dependencies for py2-argon2-cffi (python3) found: py2-cffi py2-six 
+ exit 1
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.3ale5b (%build)


RPM build errors:
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.3ale5b (%build)



You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-01fbb8/8855/summary.html

@davidlange6
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 22, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

Pull request #6187 was updated.

@davidlange6
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Tested at: a6c90e5

  • Build:

I found compilation error when building:

jupyter-run:py2-jupyter_client
jupyter-run:py3-jupyter_client
jupyter-trust:py2-nbformat
jupyter-trust:py3-nbformat
ERROR: Duplicate python binaries found. Please cleanup and make sure only one binary is available.
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.NWk5CE (%install)


RPM build errors:
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.NWk5CE (%install)



You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-01fbb8/8863/summary.html

@davidlange6
Copy link
Contributor Author

please test

@smuzaffar
Copy link
Contributor

please test
@davidlange6 , I cleaned up it a bit by adding the py3 releated dependencies in to py3-package.file files . Note the package.file file is common to both py2 and py3, so there is no need to duplicate its contents in pyX-package.file files

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 24, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-1

Tested at: 414f317

  • Build:

I found compilation error when building:

+ DEPS='py2-nbformat '
+ '[' 'py2-nbformat ' '!=' '' ']'
+ echo 'ERROR: Missing dependencies for py2-nbconvert (python3) found: py2-nbformat '
ERROR: Missing dependencies for py2-nbconvert (python3) found: py2-nbformat 
+ exit 1
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.YiBly7 (%build)


RPM build errors:
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.YiBly7 (%build)



You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-01fbb8/8895/summary.html

@cmsbuild
Copy link
Contributor

Pull request #6187 was updated.

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 25, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: e128835
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-01fbb8/8904/summary.html
CMSSW: CMSSW_11_2_X_2020-08-24-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-01fbb8/8904/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2609656
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2609633
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@davidlange6
Copy link
Contributor Author

thanks for the cleanup @smuzaffar

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_2_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar merged commit 5d6df37 into cms-sw:IB/CMSSW_11_2_X/master Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants