Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new cmssw-wm-tools tool #6263

Merged
merged 2 commits into from Sep 23, 2020
Merged

Conversation

smuzaffar
Copy link
Contributor

New cmssw-wm-tools ( https://github.com/cms-sw/cmssw-wm-tools) tool is added for tweaking CMSSW job configurations.
This will install cmssw-wm-tools/bin under CMS_PATH/share/overrides/bin and cmssw-wm-tools/python under CMS_PATH/share/overrides/python . SCRAM then adds these in PATH and PYTHON*PATH after cmsenv. This should work for all CMSSW releases (5.3X and above).

FYI @davidlange6

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 23, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_11_2_X/master.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Tested at: 8688a67

  • Build:

I found compilation error when building:

+ '[' -d /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/6cf00e03aee379f96b83822a467b28c8/opt/cmssw/slc7_amd64_gcc820/cms/cmssw-wm-tools/200923-aaccdd ']'
+ rm -fr /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/6cf00e03aee379f96b83822a467b28c8/opt/cmssw/slc7_amd64_gcc820/cms/cmssw-wm-tools/200923-aaccdd
+ echo 'ERROR: 200923-aaccdd does not match 200923. Please update version number for cmssw-wm-tools.'
ERROR: 200923-aaccdd does not match 200923. Please update version number for cmssw-wm-tools.
+ exit 1
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.fGwpJw (%prep)


RPM build errors:
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.fGwpJw (%prep)



You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aaccdd/9512/summary.html

@cmsbuild
Copy link
Contributor

Pull request #6263 was updated.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 23, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 2c15ca1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aaccdd/9513/summary.html
CMSSW: CMSSW_11_2_X_2020-09-22-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@smuzaffar
Copy link
Contributor Author

+externals
it is a new tool for deploying the cmssw tweaking scripts for WM.

@smuzaffar smuzaffar merged commit 44b4677 into IB/CMSSW_11_2_X/master Sep 23, 2020
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_2_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar deleted the cmssw-wm-tools branch September 23, 2020 09:44
@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aaccdd/9513/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2540471
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2540448
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@davidlange6
Copy link
Contributor

hi @smuzaffar - I had expected this to get installed with the 10_2_24 release that got uploaded. That didn't seem to happen - do we need an 11_2_x build instead?

@smuzaffar
Copy link
Contributor Author

No, this is only part of 11.2.X branch so should already work in 11.2.X IBs env

@davidlange6
Copy link
Contributor

davidlange6 commented Sep 24, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants