Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update EgammaAnalysis-ElectronTools to V00-03-00 #6362

Merged
merged 1 commit into from Nov 5, 2020

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Nov 3, 2020

backport of #6341

needed for cms-sw/cmssw#31995

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2020

A new Pull Request was created by @slava77 (Slava Krutelyov) for branch IB/CMSSW_10_6_X/gcc700.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#31995

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#31995

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2020

+1
Tested at: 0b698cf
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a87c42/10479/summary.html
CMSSW: CMSSW_10_6_X_2020-11-03-1100
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a87c42/10479/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 40 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 3214664
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3214328
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 140 log files, 14 edm output root files, 34 DQM output files

@smuzaffar
Copy link
Contributor

@slava77 , are these reco differences in comparison job expected?

@slava77
Copy link
Contributor Author

slava77 commented Nov 3, 2020

@slava77 , are these reco differences in comparison job expected?

yes, they are consistent with updates made in the master.
This cmsdist PR can be merged without the cms-sw/cmssw PR because the tag update in the data package corresponds to addition of a new file.

@mrodozov
Copy link
Contributor

mrodozov commented Nov 4, 2020

+externals

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2020

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_6_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Nov 5, 2020

+1

@cmsbuild cmsbuild merged commit a9d71a8 into cms-sw:IB/CMSSW_10_6_X/gcc700 Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants